[PATCH 05/16] ARM: dts: imx6qdl-aristainetos2: rename ethernet-phy to ethernet-phy@0

Frank Li posted 16 patches 5 months, 1 week ago
[PATCH 05/16] ARM: dts: imx6qdl-aristainetos2: rename ethernet-phy to ethernet-phy@0
Posted by Frank Li 5 months, 1 week ago
Rename ethernet-phy to ethernet-phy@0 to fix below CHECK_DTB warnings:
  arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dtb: ethernet@2188000 (fsl,imx6q-fec): mdio: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-aristainetos2.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-aristainetos2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-aristainetos2.dtsi
index 5a04909ff9ee13db0726d2bd6710cdcfbaf83faa..d23342ae22d07301813586521d54d6df96c608c9 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-aristainetos2.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-aristainetos2.dtsi
@@ -326,8 +326,9 @@ mdio {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethphy: ethernet-phy {
+		ethphy: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;
 			txd0-skew-ps = <0>;
 			txd1-skew-ps = <0>;
 			txd2-skew-ps = <0>;

-- 
2.34.1
Re: [PATCH 05/16] ARM: dts: imx6qdl-aristainetos2: rename ethernet-phy to ethernet-phy@0
Posted by Fabio Estevam 5 months, 1 week ago
Hi Frank,

Thanks for working on this series.

On Wed, Sep 3, 2025 at 5:20 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> Rename ethernet-phy to ethernet-phy@0 to fix below CHECK_DTB warnings:
>   arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dtb: ethernet@2188000 (fsl,imx6q-fec): mdio: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)
....

> -               ethphy: ethernet-phy {
> +               ethphy: ethernet-phy@0 {
>                         compatible = "ethernet-phy-ieee802.3-c22";
> +                       reg = <0>;

Are you sure the Ethernet PHY is actually at address 0?

The board schematics are often needed to get this information.

I'm adding Heiko on CC in case he can confirm.
Re: [PATCH 05/16] ARM: dts: imx6qdl-aristainetos2: rename ethernet-phy to ethernet-phy@0
Posted by Peng Fan 5 months, 1 week ago
On Wed, Sep 03, 2025 at 08:37:39PM -0300, Fabio Estevam wrote:
>> -               ethphy: ethernet-phy {
>> +               ethphy: ethernet-phy@0 {
>>                         compatible = "ethernet-phy-ieee802.3-c22";
>> +                       reg = <0>;
>
>Are you sure the Ethernet PHY is actually at address 0?
>
>The board schematics are often needed to get this information.

See U-Boot include/configs/aristainetos2.h line 28:
#define CFG_FEC_MXC_PHYADDR  0

The addr is 0.

Regards
Peng
Re: [PATCH 05/16] ARM: dts: imx6qdl-aristainetos2: rename ethernet-phy to ethernet-phy@0
Posted by Heiko Schocher 5 months, 1 week ago
Hello Fabio, Frank,

On 04.09.25 01:37, Fabio Estevam wrote:
> Hi Frank,
> 
> Thanks for working on this series.

+1

> On Wed, Sep 3, 2025 at 5:20 PM Frank Li <Frank.Li@nxp.com> wrote:
>>
>> Rename ethernet-phy to ethernet-phy@0 to fix below CHECK_DTB warnings:
>>    arch/arm/boot/dts/nxp/imx/imx6dl-aristainetos2_4.dtb: ethernet@2188000 (fsl,imx6q-fec): mdio: Unevaluated properties are not allowed ('ethernet-phy' was unexpected)
> ....
> 
>> -               ethphy: ethernet-phy {
>> +               ethphy: ethernet-phy@0 {
>>                          compatible = "ethernet-phy-ieee802.3-c22";
>> +                       reg = <0>;
> 
> Are you sure the Ethernet PHY is actually at address 0?
> 
> The board schematics are often needed to get this information.
> 
> I'm adding Heiko on CC in case he can confirm.

Yep, Frank was lucky, phy is @0

So, I am fine with that change.

bye,
Heiko
-- 
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Geschäftsführer : Stefano Babic