[PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.

Johnsodn Huang posted 1 patch 1 month ago
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Johnsodn Huang 1 month ago
From: Johnson Huang <kusogame68@gmail.com>

Co-developed-by: Nick Huang <sef1548@gmail.com>
Signed-off-by: Nick Huang <sef1548@gmail.com>
Signed-off-by: Johnson Huang <kusogame68@gmail.com>
---
 Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
index d783cc4e4e..d16c82e398 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
@@ -41,7 +41,7 @@ properties:
   clock-output-names:
     maxItems: 1
 
-# The BD71847 abd BD71850 support two different HW states as reset target
+# The BD71847 and BD71850 support two different HW states as reset target
 # states. States are called as SNVS and READY. At READY state all the PMIC
 # power outputs go down and OTP is reload. At the SNVS state all other logic
 # and external devices apart from the SNVS power domain are shut off. Please
-- 
2.43.0
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Lee Jones 1 month ago
Looks like you corrupted the subject line with the commit message.

Please resubmit.

> From: Johnson Huang <kusogame68@gmail.com>

Use `git format-patch` and `git send-email` instead.

> Co-developed-by: Nick Huang <sef1548@gmail.com>
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> Signed-off-by: Johnson Huang <kusogame68@gmail.com>

It took two of you to correct the word "and"?

> ---
>  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> index d783cc4e4e..d16c82e398 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> @@ -41,7 +41,7 @@ properties:
>    clock-output-names:
>      maxItems: 1
>  
> -# The BD71847 abd BD71850 support two different HW states as reset target
> +# The BD71847 and BD71850 support two different HW states as reset target
>  # states. States are called as SNVS and READY. At READY state all the PMIC
>  # power outputs go down and OTP is reload. At the SNVS state all other logic
>  # and external devices apart from the SNVS power domain are shut off. Please
> -- 
> 2.43.0
> 

-- 
Lee Jones [李琼斯]
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks, 4 days ago
Lee Jones <lee@kernel.org> 於 2025年9月3日 週三 下午3:42寫道:
>
> Looks like you corrupted the subject line with the commit message.
>
> Please resubmit.
>
> > From: Johnson Huang <kusogame68@gmail.com>
>
> Use `git format-patch` and `git send-email` instead.
>
> > Co-developed-by: Nick Huang <sef1548@gmail.com>
> > Signed-off-by: Nick Huang <sef1548@gmail.com>
> > Signed-off-by: Johnson Huang <kusogame68@gmail.com>
>
> It took two of you to correct the word "and"?
>
> > ---
> >  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > index d783cc4e4e..d16c82e398 100644
> > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > @@ -41,7 +41,7 @@ properties:
> >    clock-output-names:
> >      maxItems: 1
> >
> > -# The BD71847 abd BD71850 support two different HW states as reset target
> > +# The BD71847 and BD71850 support two different HW states as reset target
> >  # states. States are called as SNVS and READY. At READY state all the PMIC
> >  # power outputs go down and OTP is reload. At the SNVS state all other logic
> >  # and external devices apart from the SNVS power domain are shut off. Please
> > --
> > 2.43.0
> >
>
> --
> Lee Jones [李琼斯]


This patch was sent by Johnson Huang on my behalf.
If only one person should sign off, I have already discussed with him
and will keep only my own Signed-off-by.

Best regards,
Nick
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago
On 07/09/2025 15:38, Nick Huang wrote:
> Lee Jones <lee@kernel.org> 於 2025年9月3日 週三 下午3:42寫道:
>>
>> Looks like you corrupted the subject line with the commit message.
>>
>> Please resubmit.
>>
>>> From: Johnson Huang <kusogame68@gmail.com>
>>
>> Use `git format-patch` and `git send-email` instead.
>>
>>> Co-developed-by: Nick Huang <sef1548@gmail.com>
>>> Signed-off-by: Nick Huang <sef1548@gmail.com>
>>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
>>
>> It took two of you to correct the word "and"?
>>
>>> ---
>>>  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
>>> index d783cc4e4e..d16c82e398 100644
>>> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
>>> @@ -41,7 +41,7 @@ properties:
>>>    clock-output-names:
>>>      maxItems: 1
>>>
>>> -# The BD71847 abd BD71850 support two different HW states as reset target
>>> +# The BD71847 and BD71850 support two different HW states as reset target
>>>  # states. States are called as SNVS and READY. At READY state all the PMIC
>>>  # power outputs go down and OTP is reload. At the SNVS state all other logic
>>>  # and external devices apart from the SNVS power domain are shut off. Please
>>> --
>>> 2.43.0
>>>
>>
>> --
>> Lee Jones [李琼斯]
> 
> 
> This patch was sent by Johnson Huang on my behalf.

The From is malformed then. There is no single reason to change it.

> If only one person should sign off, I have already discussed with him
> and will keep only my own Signed-off-by.

For simple one letter typo? And then you sent three patches one-per-fix,
which is way too much churn.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks, 4 days ago
Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月7日 週日 下午11:07寫道:
>
> On 07/09/2025 15:38, Nick Huang wrote:
> > Lee Jones <lee@kernel.org> 於 2025年9月3日 週三 下午3:42寫道:
> >>
> >> Looks like you corrupted the subject line with the commit message.
> >>
> >> Please resubmit.
> >>
> >>> From: Johnson Huang <kusogame68@gmail.com>
> >>
> >> Use `git format-patch` and `git send-email` instead.
> >>
> >>> Co-developed-by: Nick Huang <sef1548@gmail.com>
> >>> Signed-off-by: Nick Huang <sef1548@gmail.com>
> >>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> >>
> >> It took two of you to correct the word "and"?
> >>
> >>> ---
> >>>  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> >>> index d783cc4e4e..d16c82e398 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> >>> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> >>> @@ -41,7 +41,7 @@ properties:
> >>>    clock-output-names:
> >>>      maxItems: 1
> >>>
> >>> -# The BD71847 abd BD71850 support two different HW states as reset target
> >>> +# The BD71847 and BD71850 support two different HW states as reset target
> >>>  # states. States are called as SNVS and READY. At READY state all the PMIC
> >>>  # power outputs go down and OTP is reload. At the SNVS state all other logic
> >>>  # and external devices apart from the SNVS power domain are shut off. Please
> >>> --
> >>> 2.43.0
> >>>
> >>
> >> --
> >> Lee Jones [李琼斯]
> >
> >
> > This patch was sent by Johnson Huang on my behalf.
>
> The From is malformed then. There is no single reason to change it.
>
> > If only one person should sign off, I have already discussed with him
> > and will keep only my own Signed-off-by.
>
> For simple one letter typo? And then you sent three patches one-per-fix,
> which is way too much churn.
>
> Best regards,
> Krzysztof
Currently, I sent one patch per file for fixing a single typo.
In the next version, I will combine all the typo fixes into a single
patch and resend it. Is that acceptable?

Best regards,
Nick Huang
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Matti Vaittinen 3 weeks, 1 day ago
ma 8.9.2025 klo 2.43 Nick Huang (sef1548@gmail.com) kirjoitti:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月7日 週日 下午11:07寫道:
> > On 07/09/2025 15:38, Nick Huang wrote:
> > > Lee Jones <lee@kernel.org> 於 2025年9月3日 週三 下午3:42寫道:
> > >>
> > >> Looks like you corrupted the subject line with the commit message.
> > >>
> > >> Please resubmit.
> > >>
> > >>> From: Johnson Huang <kusogame68@gmail.com>
> > >>
> > >> Use `git format-patch` and `git send-email` instead.
> > >>
> > >>> Co-developed-by: Nick Huang <sef1548@gmail.com>
> > >>> Signed-off-by: Nick Huang <sef1548@gmail.com>
> > >>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> > >>
> > >> It took two of you to correct the word "and"?
> > >>
> > >>> ---
> > >>>  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
> > >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > >>> index d783cc4e4e..d16c82e398 100644
> > >>> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > >>> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > >>> @@ -41,7 +41,7 @@ properties:
> > >>>    clock-output-names:
> > >>>      maxItems: 1
> > >>>
> > >>> -# The BD71847 abd BD71850 support two different HW states as reset target
> > >>> +# The BD71847 and BD71850 support two different HW states as reset target
> > >>>  # states. States are called as SNVS and READY. At READY state all the PMIC
> > >>>  # power outputs go down and OTP is reload. At the SNVS state all other logic
> > >>>  # and external devices apart from the SNVS power domain are shut off. Please
> > >>> --
> > >>> 2.43.0

Hi Nick,

Thanks for the typo fix. It looks good.
I, however, am curious how did you build the recipient list? I hoped
to be notified about changes to these bindings and I'm not CC'd.

Yours,
    -- Matti

-- 

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Discuss - Estimate - Plan - Report and finally accomplish this:
void do_work(int time) __attribute__ ((const));
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks ago
Matti Vaittinen <mazziesaccount@gmail.com> 於 2025年9月11日 週四 下午2:33寫道:
>
> ma 8.9.2025 klo 2.43 Nick Huang (sef1548@gmail.com) kirjoitti:
> > Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月7日 週日 下午11:07寫道:
> > > On 07/09/2025 15:38, Nick Huang wrote:
> > > > Lee Jones <lee@kernel.org> 於 2025年9月3日 週三 下午3:42寫道:
> > > >>
> > > >> Looks like you corrupted the subject line with the commit message.
> > > >>
> > > >> Please resubmit.
> > > >>
> > > >>> From: Johnson Huang <kusogame68@gmail.com>
> > > >>
> > > >> Use `git format-patch` and `git send-email` instead.
> > > >>
> > > >>> Co-developed-by: Nick Huang <sef1548@gmail.com>
> > > >>> Signed-off-by: Nick Huang <sef1548@gmail.com>
> > > >>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> > > >>
> > > >> It took two of you to correct the word "and"?
> > > >>
> > > >>> ---
> > > >>>  Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 2 +-
> > > >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>
> > > >>> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > > >>> index d783cc4e4e..d16c82e398 100644
> > > >>> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > > >>> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
> > > >>> @@ -41,7 +41,7 @@ properties:
> > > >>>    clock-output-names:
> > > >>>      maxItems: 1
> > > >>>
> > > >>> -# The BD71847 abd BD71850 support two different HW states as reset target
> > > >>> +# The BD71847 and BD71850 support two different HW states as reset target
> > > >>>  # states. States are called as SNVS and READY. At READY state all the PMIC
> > > >>>  # power outputs go down and OTP is reload. At the SNVS state all other logic
> > > >>>  # and external devices apart from the SNVS power domain are shut off. Please
> > > >>> --
> > > >>> 2.43.0
>
> Hi Nick,
>
> Thanks for the typo fix. It looks good.
> I, however, am curious how did you build the recipient list? I hoped
> to be notified about changes to these bindings and I'm not CC'd.
>
> Yours,
>     -- Matti
>
> --
>
> Matti Vaittinen
> Linux kernel developer at ROHM Semiconductors
> Oulu Finland
>
> ~~ When things go utterly wrong vim users can always type :help! ~~
>
> Discuss - Estimate - Plan - Report and finally accomplish this:
> void do_work(int time) __attribute__ ((const));

Hi Matii

I used ./scripts/get_maintainer.pl
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml to
generate the maintainer and CC list.
Sorry for missing you previously — I’m including you this time.

With the current patch, should I resend it? I’m not quite sure what
the proper next step is.

-- 
Regards,
Nick Huang
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago
On 03/09/2025 09:42, Lee Jones wrote:
> Looks like you corrupted the subject line with the commit message.
> 
> Please resubmit.
> 
>> From: Johnson Huang <kusogame68@gmail.com>
> 
> Use `git format-patch` and `git send-email` instead.
> 
>> Co-developed-by: Nick Huang <sef1548@gmail.com>
>> Signed-off-by: Nick Huang <sef1548@gmail.com>
>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> 
> It took two of you to correct the word "and"?

Can you respond to the comment instead of ignoring it and sending the same?

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks, 5 days ago
Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月6日 週六 下午3:38寫道:
>
> On 03/09/2025 09:42, Lee Jones wrote:
> > Looks like you corrupted the subject line with the commit message.
> >
> > Please resubmit.
> >
> >> From: Johnson Huang <kusogame68@gmail.com>
> >
> > Use `git format-patch` and `git send-email` instead.
> >
> >> Co-developed-by: Nick Huang <sef1548@gmail.com>
> >> Signed-off-by: Nick Huang <sef1548@gmail.com>
> >> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> >
> > It took two of you to correct the word "and"?
>
> Can you respond to the comment instead of ignoring it and sending the same?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Sure, at the moment this commit only addresses the typo in the word 'and'.

Best regards,
Nick
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Krzysztof Kozlowski 3 weeks, 5 days ago
On 06/09/2025 11:13, Nick Huang wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月6日 週六 下午3:38寫道:
>>
>> On 03/09/2025 09:42, Lee Jones wrote:
>>> Looks like you corrupted the subject line with the commit message.
>>>
>>> Please resubmit.
>>>
>>>> From: Johnson Huang <kusogame68@gmail.com>
>>>
>>> Use `git format-patch` and `git send-email` instead.
>>>
>>>> Co-developed-by: Nick Huang <sef1548@gmail.com>
>>>> Signed-off-by: Nick Huang <sef1548@gmail.com>
>>>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
>>>
>>> It took two of you to correct the word "and"?
>>
>> Can you respond to the comment instead of ignoring it and sending the same?
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> Sure, at the moment this commit only addresses the typo in the word 'and'.

Did you read the question?

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks, 5 days ago
Yes, I have read it. The subject and the content were mixed together,
so I will reorganize and resend the patch.

Best regards,
Nick

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月6日 週六 下午8:00寫道:
>
> On 06/09/2025 11:13, Nick Huang wrote:
> > Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月6日 週六 下午3:38寫道:
> >>
> >> On 03/09/2025 09:42, Lee Jones wrote:
> >>> Looks like you corrupted the subject line with the commit message.
> >>>
> >>> Please resubmit.
> >>>
> >>>> From: Johnson Huang <kusogame68@gmail.com>
> >>>
> >>> Use `git format-patch` and `git send-email` instead.
> >>>
> >>>> Co-developed-by: Nick Huang <sef1548@gmail.com>
> >>>> Signed-off-by: Nick Huang <sef1548@gmail.com>
> >>>> Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> >>>
> >>> It took two of you to correct the word "and"?
> >>
> >> Can you respond to the comment instead of ignoring it and sending the same?
> >>
> >> Best regards,
> >> Krzysztof
> >
> > Hi Krzysztof,
> >
> > Sure, at the moment this commit only addresses the typo in the word 'and'.
>
> Did you read the question?
>
> Best regards,
> Krzysztof
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Krzysztof Kozlowski 3 weeks, 5 days ago
On 06/09/2025 15:09, Nick Huang wrote:
> Yes, I have read it. The subject and the content were mixed together,
> so I will reorganize and resend the patch.

Please do not top-post.

The question was not about subject and content. I just don't believe the
DCO chain here.

Best regards,
Krzysztof
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Nick Huang 3 weeks, 5 days ago
Krzysztof Kozlowski <krzk@kernel.org> 於 2025年9月7日 週日 下午4:17寫道:
>
> On 06/09/2025 15:09, Nick Huang wrote:
> > Yes, I have read it. The subject and the content were mixed together,
> > so I will reorganize and resend the patch.
>
> Please do not top-post.
>
> The question was not about subject and content. I just don't believe the
> DCO chain here.
>
> Best regards,
> Krzysztof

Can you tell me what’s wrong with the DCO chain?

Best regards,
Nick
Re: [PATCH] dt-bindings: fix typo in documentation Correct a typo in the documentation by replacing "abd" with the correct word "and". This improves readability and avoids confusion in the description.
Posted by Krzysztof Kozlowski 1 month ago
On Wed, Sep 03, 2025 at 08:42:05AM +0100, Lee Jones wrote:
> Looks like you corrupted the subject line with the commit message.
> 
> Please resubmit.
> 
> > From: Johnson Huang <kusogame68@gmail.com>
> 
> Use `git format-patch` and `git send-email` instead.
> 
> > Co-developed-by: Nick Huang <sef1548@gmail.com>
> > Signed-off-by: Nick Huang <sef1548@gmail.com>
> > Signed-off-by: Johnson Huang <kusogame68@gmail.com>
> 
> It took two of you to correct the word "and"?

And this is so trivial that I would suggest to fix ALL the typos in MFD
bindings at once. For sure there are more...

Best regards,
Krzysztof