i3c: master: Remove ternary operator on return statement

[PATCH][next] i3c: master: Remove ternary operator on return statement

Posted by Colin Ian King 1 month ago

The value of ret at the end of the function renesas_i3c_daa
is always zero since previous checks for less than zero have already
exited via return paths. Hence the final ternary operator checking
for a less than zero value for ret is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/i3c/master/renesas-i3c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
index 174d3dc5d276..275f7b924288 100644
--- a/drivers/i3c/master/renesas-i3c.c
+++ b/drivers/i3c/master/renesas-i3c.c
@@ -679,7 +679,7 @@ static int renesas_i3c_daa(struct i3c_master_controller *m)
 			i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
 	}
 
-	return ret < 0 ? ret : 0;
+	return 0;
 }
 
 static bool renesas_i3c_supports_ccc_cmd(struct i3c_master_controller *m,
-- 
2.51.0

Re: [PATCH][next] i3c: master: Remove ternary operator on return statement

Posted by Wolfram Sang 2 weeks, 4 days ago

On Tue, Sep 02, 2025 at 02:52:39PM +0100, Colin Ian King wrote:
> The value of ret at the end of the function renesas_i3c_daa
> is always zero since previous checks for less than zero have already
> exited via return paths. Hence the final ternary operator checking
> for a less than zero value for ret is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Already sent (and applied just today):

https://lore.kernel.org/r/20250803211256.18513-2-wsa+renesas@sang-engineering.com