[PATCH 1/6] scsi: arcmsr: Remove redundant ternary operators

Liao Yuanhong posted 6 patches 1 month ago
[PATCH 1/6] scsi: arcmsr: Remove redundant ternary operators
Posted by Liao Yuanhong 1 month ago
Remove redundant ternary operators to clean up the code.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 drivers/scsi/arcmsr/arcmsr_hba.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index fb57343a97bd..fd321af14d0e 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -4584,14 +4584,14 @@ static bool arcmsr_reset_in_progress(struct AdapterControlBlock *acb)
 	switch(acb->adapter_type) {
 	case ACB_ADAPTER_TYPE_A:{
 		struct MessageUnit_A __iomem *reg = acb->pmuA;
-		rtn = ((readl(&reg->outbound_msgaddr1) &
-			ARCMSR_OUTBOUND_MESG1_FIRMWARE_OK) == 0) ? true : false;
+		rtn = (readl(&reg->outbound_msgaddr1) &
+			ARCMSR_OUTBOUND_MESG1_FIRMWARE_OK) == 0;
 		}
 		break;
 	case ACB_ADAPTER_TYPE_B:{
 		struct MessageUnit_B *reg = acb->pmuB;
-		rtn = ((readl(reg->iop2drv_doorbell) &
-			ARCMSR_MESSAGE_FIRMWARE_OK) == 0) ? true : false;
+		rtn = (readl(reg->iop2drv_doorbell) &
+			ARCMSR_MESSAGE_FIRMWARE_OK) == 0;
 		}
 		break;
 	case ACB_ADAPTER_TYPE_C:{
@@ -4601,8 +4601,7 @@ static bool arcmsr_reset_in_progress(struct AdapterControlBlock *acb)
 		break;
 	case ACB_ADAPTER_TYPE_D:{
 		struct MessageUnit_D *reg = acb->pmuD;
-		rtn = ((readl(reg->sample_at_reset) & 0x80) == 0) ?
-			true : false;
+		rtn = (readl(reg->sample_at_reset) & 0x80) == 0;
 		}
 		break;
 	case ACB_ADAPTER_TYPE_E:
-- 
2.34.1