ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message

[PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message

Posted by Colin Ian King 1 month ago

There appears to be a cut-n-paste error with the incorrect field
ndr_desc->numa_node being reported for the target node. Fix this by
using ndr_desc->target_node instead.

Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/acpi/nfit/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index ae035b93da08..3eb56b77cb6d 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
 	if (ndr_desc->target_node == NUMA_NO_NODE) {
 		ndr_desc->target_node = phys_to_target_node(spa->address);
 		dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
-			NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
+			NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
 	}
 
 	/*
-- 
2.51.0

Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message

Posted by Rafael J. Wysocki 4 weeks ago

On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There appears to be a cut-n-paste error with the incorrect field
> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
>
> Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index ae035b93da08..3eb56b77cb6d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
>         if (ndr_desc->target_node == NUMA_NO_NODE) {
>                 ndr_desc->target_node = phys_to_target_node(spa->address);
>                 dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> -                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> +                       NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
>         }
>
>         /*
> --

Dan, Dave, are you guys going to take this one, or should I take care of it?

Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message

Posted by Ira Weiny 4 weeks ago

Rafael J. Wysocki wrote:
> On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > There appears to be a cut-n-paste error with the incorrect field
> > ndr_desc->numa_node being reported for the target node. Fix this by
> > using ndr_desc->target_node instead.
> >
> > Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> >  drivers/acpi/nfit/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index ae035b93da08..3eb56b77cb6d 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> >         if (ndr_desc->target_node == NUMA_NO_NODE) {
> >                 ndr_desc->target_node = phys_to_target_node(spa->address);
> >                 dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> > -                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> > +                       NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> >         }
> >
> >         /*
> > --
> 
> Dan, Dave, are you guys going to take this one, or should I take care of it?

Apologies, I should have said I'm taking this one.  It is queued up.

Thanks for the ping,
Ira

Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message

Posted by Ira Weiny 1 month ago

Colin Ian King wrote:
> There appears to be a cut-n-paste error with the incorrect field

NIT: 'There __is__ a cut-n-paste error..."  ;-)

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
> 
> Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index ae035b93da08..3eb56b77cb6d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
>  	if (ndr_desc->target_node == NUMA_NO_NODE) {
>  		ndr_desc->target_node = phys_to_target_node(spa->address);
>  		dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> -			NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> +			NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
>  	}
>  
>  	/*
> -- 
> 2.51.0
>