[PATCH v5] net/core: Replace offensive comment in skbuff.c

mysteryli posted 1 patch 1 month ago
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v5] net/core: Replace offensive comment in skbuff.c
Posted by mysteryli 1 month ago
From: Mystery <m13940358460@163.com>

The original comment contained profanity to express the frustration of
dealing with a complex and resource-constrained code path. While the
sentiment is understandable, the language is unprofessional and
unnecessary.
Replace it with a more neutral and descriptive comment that maintains
the original technical context and conveys the difficulty of the
situation without the use of offensive language.
Indeed, I do not believe this will offend any particular individual or group.
Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.

v5:

- Added this detailed changelog section

v4:https://lore.kernel.org/netdev/20250901060635.735038-1-m13940358460@163.com/
- Fixed incorrect Signed-off-by format (removed quotes) as requested by Andrew Lunn
- Consolidated multiple versions (v1/v2) into a single version history

v3:Due to some local reasons in my area, this is a lost version. I'm truly sorry

v2:https://lore.kernel.org/netdev/20250901055802.727743-1-m13940358460@163.com/
- Initial version addressing feedback

v1:https://lore.kernel.org/netdev/20250828084253.1719646-1-m13940358460@163.com/
- First submission

Signed-off-by: Mystery Li <m13940358460@163.com>
---
 net/core/skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ee0274417948..202c25a01f22 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -5333,7 +5333,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer)
 		    skb_has_frag_list(skb1)) {
 			struct sk_buff *skb2;
 
-			/* Fuck, we are miserable poor guys... */
+			/* This is a painfully difficult situation with limited resources... */
 			if (ntail == 0)
 				skb2 = skb_copy(skb1, GFP_ATOMIC);
 			else
-- 
2.25.1
Re: [PATCH v5] net/core: Replace offensive comment in skbuff.c
Posted by Jason Xing 1 month ago
On Tue, Sep 2, 2025 at 10:26 AM mysteryli <m13940358460@163.com> wrote:
>
> From: Mystery <m13940358460@163.com>
>
> The original comment contained profanity to express the frustration of
> dealing with a complex and resource-constrained code path. While the
> sentiment is understandable, the language is unprofessional and
> unnecessary.
> Replace it with a more neutral and descriptive comment that maintains
> the original technical context and conveys the difficulty of the
> situation without the use of offensive language.
> Indeed, I do not believe this will offend any particular individual or group.
> Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.
>
> v5:
>
> - Added this detailed changelog section
>
> v4:https://lore.kernel.org/netdev/20250901060635.735038-1-m13940358460@163.com/
> - Fixed incorrect Signed-off-by format (removed quotes) as requested by Andrew Lunn
> - Consolidated multiple versions (v1/v2) into a single version history
>
> v3:Due to some local reasons in my area, this is a lost version. I'm truly sorry
>
> v2:https://lore.kernel.org/netdev/20250901055802.727743-1-m13940358460@163.com/
> - Initial version addressing feedback
>
> v1:https://lore.kernel.org/netdev/20250828084253.1719646-1-m13940358460@163.com/
> - First submission
>
> Signed-off-by: Mystery Li <m13940358460@163.com>

IIUC, you've received an explicit NACK from Jakub at the previous link
https://lore.kernel.org/netdev/20250901114157.5345a56a@kernel.org/.

Thanks,
Jason