drm: Implement state readout support

[PATCH 11/29] drm/crtc: Drop no_vblank bit field

Posted by Maxime Ripard 1 month ago

The no_vblank field in drm_crtc_state is defined as a bit-field with a
single bit.

This will create a syntax issue with the macros we'll introduce next,
and most other booleans but the *_changed ones in drm_crtc_state do not
use a bit field anyway.

Let's drop it.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
 include/drm/drm_crtc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index c462bd9b2f7d3ae08e669463717002e5f78122fe..11e3299cfad1572c6e507918c7cceae7a28ba4cf 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -184,11 +184,11 @@ struct drm_crtc_state {
 	 * &drm_crtc_state.no_blank == true is valid and usually used when the
 	 * writeback connector attached to the CRTC has a new job queued. In
 	 * this case the driver will send the VBLANK event on its own when the
 	 * writeback job is complete.
 	 */
-	bool no_vblank : 1;
+	bool no_vblank;
 
 	/**
 	 * @plane_mask: Bitmask of drm_plane_mask(plane) of planes attached to
 	 * this CRTC.
 	 */

-- 
2.50.1

Re: [PATCH 11/29] drm/crtc: Drop no_vblank bit field

Posted by Thomas Zimmermann 1 month ago


Am 02.09.25 um 10:32 schrieb Maxime Ripard:
> The no_vblank field in drm_crtc_state is defined as a bit-field with a
> single bit.
>
> This will create a syntax issue with the macros we'll introduce next,
> and most other booleans but the *_changed ones in drm_crtc_state do not
> use a bit field anyway.
>
> Let's drop it.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   include/drm/drm_crtc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index c462bd9b2f7d3ae08e669463717002e5f78122fe..11e3299cfad1572c6e507918c7cceae7a28ba4cf 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -184,11 +184,11 @@ struct drm_crtc_state {
>   	 * &drm_crtc_state.no_blank == true is valid and usually used when the
>   	 * writeback connector attached to the CRTC has a new job queued. In
>   	 * this case the driver will send the VBLANK event on its own when the
>   	 * writeback job is complete.
>   	 */
> -	bool no_vblank : 1;
> +	bool no_vblank;
>   
>   	/**
>   	 * @plane_mask: Bitmask of drm_plane_mask(plane) of planes attached to
>   	 * this CRTC.
>   	 */
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: (subset) [PATCH 11/29] drm/crtc: Drop no_vblank bit field

Posted by Maxime Ripard 3 days, 1 hour ago

On Tue, 02 Sep 2025 10:32:39 +0200, Maxime Ripard wrote:
> The no_vblank field in drm_crtc_state is defined as a bit-field with a
> single bit.
> 
> This will create a syntax issue with the macros we'll introduce next,
> and most other booleans but the *_changed ones in drm_crtc_state do not
> use a bit field anyway.
> 
> [...]

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime