[v2] Add Ethernet and GMAC clocks for Renesas RZ/{T2H, N2H} SoCs

[PATCH v2 1/2] dt-bindings: clock: renesas,r9a09g077/87: Add Ethernet and GMAC clocks

Posted by Prabhakar 1 month ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Add clock definitions for Ethernet (ETCLK A-E) and GMAC (GMAC0-2)
peripherals to both R9A09G077 and R9A09G087 SoCs. These definitions
are required for describing Ethernet and GMAC devices in device trees.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
v1->v2:
- Added Acked-by tag from Conor.
---
 include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h | 9 +++++++++
 include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
index 0c2ce81a8744..a9e88b0c502d 100644
--- a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
+++ b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
@@ -26,5 +26,14 @@
 #define R9A09G077_CLK_PCLKL		14
 #define R9A09G077_SDHI_CLKHS		15
 #define R9A09G077_USB_CLK		16
+#define R9A09G077_ETCLKA		17
+#define R9A09G077_ETCLKB		18
+#define R9A09G077_ETCLKC		19
+#define R9A09G077_ETCLKD		20
+#define R9A09G077_ETCLKE		21
+#define R9A09G077_GMAC0_PCLKH		22
+#define R9A09G077_GMAC1_PCLKAH		23
+#define R9A09G077_GMAC2_PCLKAH		24
+
 
 #endif /* __DT_BINDINGS_CLOCK_RENESAS_R9A09G077_CPG_H__ */
diff --git a/include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h b/include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h
index 70ee883f2386..c86ffa68f87c 100644
--- a/include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h
+++ b/include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h
@@ -26,5 +26,14 @@
 #define R9A09G087_CLK_PCLKL		14
 #define R9A09G087_SDHI_CLKHS		15
 #define R9A09G087_USB_CLK		16
+#define R9A09G087_ETCLKA		17
+#define R9A09G087_ETCLKB		18
+#define R9A09G087_ETCLKC		19
+#define R9A09G087_ETCLKD		20
+#define R9A09G087_ETCLKE		21
+#define R9A09G087_GMAC0_PCLKH		22
+#define R9A09G087_GMAC1_PCLKAH		23
+#define R9A09G087_GMAC2_PCLKAH		24
+
 
 #endif /* __DT_BINDINGS_CLOCK_RENESAS_R9A09G087_CPG_H__ */
-- 
2.51.0

Re: [PATCH v2 1/2] dt-bindings: clock: renesas,r9a09g077/87: Add Ethernet and GMAC clocks

Posted by Geert Uytterhoeven 1 month ago

Hi Prabhakar,

On Mon, 1 Sept 2025 at 20:30, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add clock definitions for Ethernet (ETCLK A-E) and GMAC (GMAC0-2)
> peripherals to both R9A09G077 and R9A09G087 SoCs. These definitions
> are required for describing Ethernet and GMAC devices in device trees.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for your patch!

> --- a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> +++ b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> @@ -26,5 +26,14 @@
>  #define R9A09G077_CLK_PCLKL            14
>  #define R9A09G077_SDHI_CLKHS           15
>  #define R9A09G077_USB_CLK              16
> +#define R9A09G077_ETCLKA               17
> +#define R9A09G077_ETCLKB               18
> +#define R9A09G077_ETCLKC               19
> +#define R9A09G077_ETCLKD               20
> +#define R9A09G077_ETCLKE               21

These five LGTM.

> +#define R9A09G077_GMAC0_PCLKH          22
> +#define R9A09G077_GMAC1_PCLKAH         23
> +#define R9A09G077_GMAC2_PCLKAH         24

I doubt you really need these, cfr. my comments on [PATCH v2 2/2].

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 1/2] dt-bindings: clock: renesas,r9a09g077/87: Add Ethernet and GMAC clocks

Posted by Lad, Prabhakar 1 month ago

Hi Geert,

Thank you for the review.

On Tue, Sep 2, 2025 at 2:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, 1 Sept 2025 at 20:30, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add clock definitions for Ethernet (ETCLK A-E) and GMAC (GMAC0-2)
> > peripherals to both R9A09G077 and R9A09G087 SoCs. These definitions
> > are required for describing Ethernet and GMAC devices in device trees.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks for your patch!
>
> > --- a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> > +++ b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> > @@ -26,5 +26,14 @@
> >  #define R9A09G077_CLK_PCLKL            14
> >  #define R9A09G077_SDHI_CLKHS           15
> >  #define R9A09G077_USB_CLK              16
> > +#define R9A09G077_ETCLKA               17
> > +#define R9A09G077_ETCLKB               18
> > +#define R9A09G077_ETCLKC               19
> > +#define R9A09G077_ETCLKD               20
> > +#define R9A09G077_ETCLKE               21
>
> These five LGTM.
>
> > +#define R9A09G077_GMAC0_PCLKH          22
> > +#define R9A09G077_GMAC1_PCLKAH         23
> > +#define R9A09G077_GMAC2_PCLKAH         24
>
> I doubt you really need these, cfr. my comments on [PATCH v2 2/2].
>
As agreed on patch 2/2, I will drop these macros in v3.

Cheers,
Prabhakar