1. Patchew
  2. linux
  3. View series

[PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()

Osama Abdelkader posted 1 patch 1 month ago
There is a newer version of this series
drivers/thermal/thermal_hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Osama Abdelkader 1 month ago 
strcpy() is deprecated; use strscpy() instead.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 drivers/thermal/thermal_hwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index 0ecccd4d8556..64cc3ab949fe 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
 
 	mutex_lock(&thermal_hwmon_list_lock);
 	list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
-		strcpy(type, tz->type);
+		strscpy(type, tz->type);
 		strreplace(type, '-', '_');
 		if (!strcmp(hwmon->type, type)) {
 			mutex_unlock(&thermal_hwmon_list_lock);
-- 
2.43.0
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Rafael J. Wysocki 4 weeks, 1 day ago 
On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> strcpy() is deprecated; use strscpy() instead.

So why is it better to use strscpy() in this particular case?

> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>  drivers/thermal/thermal_hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index 0ecccd4d8556..64cc3ab949fe 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
>
>         mutex_lock(&thermal_hwmon_list_lock);
>         list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> -               strcpy(type, tz->type);
> +               strscpy(type, tz->type);
>                 strreplace(type, '-', '_');
>                 if (!strcmp(hwmon->type, type)) {
>                         mutex_unlock(&thermal_hwmon_list_lock);
> --
> 2.43.0
>
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Osama Abdelkader 4 weeks, 1 day ago 
On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> <osama.abdelkader@gmail.com> wrote:
> >
> > strcpy() is deprecated; use strscpy() instead.
> 
> So why is it better to use strscpy() in this particular case?

Thanks for the review. Technically, there is no change since both have const buf size,
it's just for consistency with other drivers.

Regards,
Osama

> 
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > ---
> >  drivers/thermal/thermal_hwmon.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> > index 0ecccd4d8556..64cc3ab949fe 100644
> > --- a/drivers/thermal/thermal_hwmon.c
> > +++ b/drivers/thermal/thermal_hwmon.c
> > @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
> >
> >         mutex_lock(&thermal_hwmon_list_lock);
> >         list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> > -               strcpy(type, tz->type);
> > +               strscpy(type, tz->type);
> >                 strreplace(type, '-', '_');
> >                 if (!strcmp(hwmon->type, type)) {
> >                         mutex_unlock(&thermal_hwmon_list_lock);
> > --
> > 2.43.0
> >
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Rafael J. Wysocki 4 weeks, 1 day ago 
On Wed, Sep 3, 2025 at 4:04 PM Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> > On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> > <osama.abdelkader@gmail.com> wrote:
> > >
> > > strcpy() is deprecated; use strscpy() instead.
> >
> > So why is it better to use strscpy() in this particular case?
>
> Thanks for the review. Technically, there is no change since both have const buf size,
> it's just for consistency with other drivers.

$ cd linux-kernel-source
$ git grep strcpy | wc -l
1187

What kind of consistency do you mean?
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Osama Abdelkader 4 weeks, 1 day ago 
On Wed, Sep 03, 2025 at 04:21:35PM +0200, Rafael J. Wysocki wrote:
> On Wed, Sep 3, 2025 at 4:04 PM Osama Abdelkader
> <osama.abdelkader@gmail.com> wrote:
> >
> > On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> > > On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> > > <osama.abdelkader@gmail.com> wrote:
> > > >
> > > > strcpy() is deprecated; use strscpy() instead.
> > >
> > > So why is it better to use strscpy() in this particular case?
> >
> > Thanks for the review. Technically, there is no change since both have const buf size,
> > it's just for consistency with other drivers.
> 
> $ cd linux-kernel-source
> $ git grep strcpy | wc -l
> 1187
> 
> What kind of consistency do you mean?

I mean in thermal subsystem, it's only this one.
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Rafael J. Wysocki 4 weeks, 1 day ago 
On Wed, Sep 3, 2025 at 7:29 PM Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> On Wed, Sep 03, 2025 at 04:21:35PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Sep 3, 2025 at 4:04 PM Osama Abdelkader
> > <osama.abdelkader@gmail.com> wrote:
> > >
> > > On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> > > > On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> > > > <osama.abdelkader@gmail.com> wrote:
> > > > >
> > > > > strcpy() is deprecated; use strscpy() instead.
> > > >
> > > > So why is it better to use strscpy() in this particular case?
> > >
> > > Thanks for the review. Technically, there is no change since both have const buf size,
> > > it's just for consistency with other drivers.
> >
> > $ cd linux-kernel-source
> > $ git grep strcpy | wc -l
> > 1187
> >
> > What kind of consistency do you mean?
>
> I mean in thermal subsystem, it's only this one.

So please add this information to the patch changelog.
Re: [PATCH] thermal: hwmon: replace deprecated strcpy() with strscpy()
Posted by Osama Abdelkader 4 weeks, 1 day ago 
On Wed, Sep 03, 2025 at 08:36:19PM +0200, Rafael J. Wysocki wrote:
> On Wed, Sep 3, 2025 at 7:29 PM Osama Abdelkader
> <osama.abdelkader@gmail.com> wrote:
> >
> > On Wed, Sep 03, 2025 at 04:21:35PM +0200, Rafael J. Wysocki wrote:
> > > On Wed, Sep 3, 2025 at 4:04 PM Osama Abdelkader
> > > <osama.abdelkader@gmail.com> wrote:
> > > >
> > > > On Wed, Sep 03, 2025 at 01:50:03PM +0200, Rafael J. Wysocki wrote:
> > > > > On Mon, Sep 1, 2025 at 5:06 PM Osama Abdelkader
> > > > > <osama.abdelkader@gmail.com> wrote:
> > > > > >
> > > > > > strcpy() is deprecated; use strscpy() instead.
> > > > >
> > > > > So why is it better to use strscpy() in this particular case?
> > > >
> > > > Thanks for the review. Technically, there is no change since both have const buf size,
> > > > it's just for consistency with other drivers.
> > >
> > > $ cd linux-kernel-source
> > > $ git grep strcpy | wc -l
> > > 1187
> > >
> > > What kind of consistency do you mean?
> >
> > I mean in thermal subsystem, it's only this one.
> 
> So please add this information to the patch changelog.

Sure, I just sent v2.

Thanks,
Osama

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.