On Mon, Sep 01, 2025 at 02:30:20PM +0200, Max Kellermann wrote:
> We select certain test functions which either invoke each other,
> functions that are already const-ified, or no further functions.
>
> It is therefore relatively trivial to const-ify them, which
> provides a basis for further const-ification further up the call
> stack.
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
(Again, on basis of us figuring out whether we want the double-const)
LGTM, so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> include/linux/fs.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3b9f54446db0..8dc46337467d 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -537,7 +537,8 @@ struct address_space {
> /*
> * Returns true if any of the pages in the mapping are marked with the tag.
> */
> -static inline bool mapping_tagged(struct address_space *mapping, xa_mark_t tag)
> +static inline bool mapping_tagged(const struct address_space *const mapping,
> + const xa_mark_t tag)
> {
> return xa_marked(&mapping->i_pages, tag);
> }
> @@ -585,7 +586,7 @@ static inline void i_mmap_assert_write_locked(struct address_space *mapping)
> /*
> * Might pages of this file be mapped into userspace?
> */
> -static inline int mapping_mapped(struct address_space *mapping)
> +static inline int mapping_mapped(const struct address_space *const mapping)
> {
> return !RB_EMPTY_ROOT(&mapping->i_mmap.rb_root);
> }
> @@ -599,7 +600,7 @@ static inline int mapping_mapped(struct address_space *mapping)
> * If i_mmap_writable is negative, no new writable mappings are allowed. You
> * can only deny writable mappings, if none exists right now.
> */
> -static inline int mapping_writably_mapped(struct address_space *mapping)
> +static inline int mapping_writably_mapped(const struct address_space *const mapping)
> {
> return atomic_read(&mapping->i_mmap_writable) > 0;
> }
> --
> 2.47.2
>