Add compatible string for the DisplayPort controller found on the
Qualcomm QCS8300 SoC.
The Qualcomm QCS8300 platform comes with one DisplayPort controller
that supports 4 MST streams.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../bindings/display/msm/dp-controller.yaml | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 8282f3ca45c8b18f159670a7d8c4d9515cdb62ca..4f0dd80aebd1958327a06d31664dd68e02e5ba94 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7180-dp
- qcom,sc7280-dp
@@ -195,6 +196,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,x1e80100-dp
then:
@@ -283,6 +285,23 @@ allOf:
minItems: 6
maxItems: 8
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ # QCS8300 only has one DP controller that supports 4
+ # streams MST.
+ - qcom,qcs8300-dp
+ then:
+ properties:
+ reg:
+ minItems: 9
+ maxItems: 9
+ clocks:
+ minItems: 8
+ maxItems: 8
+
additionalProperties: false
examples:
--
2.34.1On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm QCS8300 SoC. > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > that supports 4 MST streams. > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > --- > .../bindings/display/msm/dp-controller.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I've picked up the last version of the DP MST patchset. Could you please rebase this patchset on top of it, hopefully making it finally mergeable. -- With best wishes Dmitry
On 9/4/2025 7:45 AM, Dmitry Baryshkov wrote: > On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: >> Add compatible string for the DisplayPort controller found on the >> Qualcomm QCS8300 SoC. >> >> The Qualcomm QCS8300 platform comes with one DisplayPort controller >> that supports 4 MST streams. >> >> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> >> --- >> .../bindings/display/msm/dp-controller.yaml | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) > > I've picked up the last version of the DP MST patchset. Could you please > rebase this patchset on top of it, hopefully making it finally > mergeable. > > Sure. will update it.
On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: > + - if: > + properties: > + compatible: > + contains: > + enum: > + # QCS8300 only has one DP controller that supports 4 > + # streams MST. > + - qcom,qcs8300-dp > + then: > + properties: > + reg: > + minItems: 9 > + maxItems: 9 > + clocks: > + minItems: 8 > + maxItems: 8 Clocks have only five items, reg has 5. At least in my next from few days ago. Nothing explains any patchset dependencies, so this makes reviewing more difficult than it should be. Best regards, Krzysztof
On 02/09/2025 08:38, Krzysztof Kozlowski wrote: > On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + # QCS8300 only has one DP controller that supports 4 >> + # streams MST. >> + - qcom,qcs8300-dp >> + then: >> + properties: >> + reg: >> + minItems: 9 >> + maxItems: 9 >> + clocks: >> + minItems: 8 >> + maxItems: 8 > > Clocks have only five items, reg has 5. At least in my next from few > days ago. > > Nothing explains any patchset dependencies, so this makes reviewing more > difficult than it should be. OK, I found the dependency in cover letter (I was looking at wrong cover letter), but the dependency does not have relevant clock changes, so this is still wrong. I suggest to slow down with this patchset. It's v10 already with simultaneous other changes and two (!!!) dependencies. I don't know how I am supposed to review this. Best regards, Krzysztof
On 9/2/2025 2:41 PM, Krzysztof Kozlowski wrote: > On 02/09/2025 08:38, Krzysztof Kozlowski wrote: >> On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + # QCS8300 only has one DP controller that supports 4 >>> + # streams MST. >>> + - qcom,qcs8300-dp >>> + then: >>> + properties: >>> + reg: >>> + minItems: 9 >>> + maxItems: 9 >>> + clocks: >>> + minItems: 8 >>> + maxItems: 8 >> >> Clocks have only five items, reg has 5. At least in my next from few >> days ago. >> >> Nothing explains any patchset dependencies, so this makes reviewing more >> difficult than it should be. > OK, I found the dependency in cover letter (I was looking at wrong cover > letter), but the dependency does not have relevant clock changes, so > this is still wrong. > Hi, https://lore.kernel.org/all/20250829-dp_mst_bindings-v7-7-2b268a43917b@oss.qualcomm.com/ dp-controller.yaml descriptions for regs and clks have been added. Compare with SA8775P, QCS8300 don't have DP1 controller which supports 2 streams MST, so its minItems and maxItems clocks is 8. > I suggest to slow down with this patchset. It's v10 already with > simultaneous other changes and two (!!!) dependencies. > Sorry for that, will wait until the dependencies become stable before updating the patch.> I don't know how I am supposed to review this. > > Best regards, > Krzysztof
On Tue, Sep 02, 2025 at 03:42:55PM +0800, Yongxing Mou wrote: > > > On 9/2/2025 2:41 PM, Krzysztof Kozlowski wrote: > > On 02/09/2025 08:38, Krzysztof Kozlowski wrote: > > > On Mon, Sep 01, 2025 at 05:57:30PM +0800, Yongxing Mou wrote: > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + # QCS8300 only has one DP controller that supports 4 > > > > + # streams MST. > > > > + - qcom,qcs8300-dp > > > > + then: > > > > + properties: > > > > + reg: > > > > + minItems: 9 > > > > + maxItems: 9 > > > > + clocks: > > > > + minItems: 8 > > > > + maxItems: 8 > > > > > > Clocks have only five items, reg has 5. At least in my next from few > > > days ago. > > > > > > Nothing explains any patchset dependencies, so this makes reviewing more > > > difficult than it should be. > > OK, I found the dependency in cover letter (I was looking at wrong cover > > letter), but the dependency does not have relevant clock changes, so > > this is still wrong. > > > Hi, https://lore.kernel.org/all/20250829-dp_mst_bindings-v7-7-2b268a43917b@oss.qualcomm.com/ > dp-controller.yaml descriptions for regs and clks have been added. Compare > with SA8775P, QCS8300 don't have DP1 controller which supports 2 streams > MST, so its minItems and maxItems clocks is 8. > I suggest to slow down with > this patchset. It's v10 already with > > simultaneous other changes and two (!!!) dependencies. > > Sorry for that, will wait until the dependencies become stable before > updating the patch.> I don't know how I am supposed to review this. Please fix you email client. This is garbled. It mixes your text and Krzysztof's on the same line. > > > > Best regards, > > Krzysztof > -- With best wishes Dmitry
© 2016 - 2025 Red Hat, Inc.