Hi Laurent,
thanks for your feedback!
On Sun, Sep 07, 2025 at 10:20:49PM +0200, Laurent Pinchart wrote:
> Hi Richard,
>
> Thank you for the patch.
>
> On Mon, Sep 01, 2025 at 05:05:13PM +0200, Richard Leitner wrote:
> > Add read-only V4L2_CID_FLASH_STROBE_SOURCE control. Its value is fixed
> > to V4L2_FLASH_STROBE_SOURCE_EXTERNAL as the camera sensor triggers the
> > strobe based on its register settings.
>
> I don't think you should implement this control in the sensor driver. It
> should only be implemented in the flash controller driver to select the
> source.
Totally true. This was introduced in the first version of this series to
enable the flash output. Now as we have V4L2_CID_FLASH_STROBE_SOURCE (or
however it will be named finally) this, for no reason, became a read-only
property. This shouldn't be there at all.
Thanks for the catch. I will remove it from the series!
>
> > Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
> > ---
> > drivers/media/i2c/ov9282.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> > index c405e3411daf37cf98d5af3535702f8321394af5..9efc82a1929a76c6fb245e7dbfb5276a133d1c5d 100644
> > --- a/drivers/media/i2c/ov9282.c
> > +++ b/drivers/media/i2c/ov9282.c
> > @@ -1368,11 +1368,12 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
> > struct v4l2_ctrl_handler *ctrl_hdlr = &ov9282->ctrl_handler;
> > const struct ov9282_mode *mode = ov9282->cur_mode;
> > struct v4l2_fwnode_device_properties props;
> > + struct v4l2_ctrl *ctrl;
> > u32 hblank_min;
> > u32 lpfr;
> > int ret;
> >
> > - ret = v4l2_ctrl_handler_init(ctrl_hdlr, 12);
> > + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 13);
> > if (ret)
> > return ret;
> >
> > @@ -1443,6 +1444,14 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
> > v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION,
> > 0, 13900, 1, 8);
> >
> > + ctrl = v4l2_ctrl_new_std_menu(ctrl_hdlr, &ov9282_ctrl_ops,
> > + V4L2_CID_FLASH_STROBE_SOURCE,
> > + V4L2_FLASH_STROBE_SOURCE_EXTERNAL,
> > + ~(1 << V4L2_FLASH_STROBE_SOURCE_EXTERNAL),
> > + V4L2_FLASH_STROBE_SOURCE_EXTERNAL);
> > + if (ctrl)
> > + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> > +
> > ret = v4l2_fwnode_device_parse(ov9282->dev, &props);
> > if (!ret) {
> > /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */
>
> --
> Regards,
>
> Laurent Pinchart
thanks again!
regards;rl