media: allegro: fixes and improvements

[PATCH 0/3] media: allegro: fixes and improvements

Posted by Matthias Fend 5 months, 1 week ago

Several fixes and improvements for the Allegro DVT video IP encoder.
These relate to race conditions that occur when multiple streams are used
simultaneously.
The problems could be reproduced on a ZCU-104 eval board with VCU firmware
version 2019.2 on various kernel versions (6.4, 6.12 and 6.16).
It is highly likely that these problems can also occur with other firmware
versions.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
---
Matthias Fend (3):
      media: allegro: print warning if channel creation timeout occurs
      media: allegro: process all pending status mbox messages
      media: allegro: fix race conditions in channel handling

 drivers/media/platform/allegro-dvt/allegro-core.c | 114 +++++++++++++++++-----
 1 file changed, 91 insertions(+), 23 deletions(-)
---
base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0
change-id: 20250901-allegro-dvt-fixes-932f2c97063e

Best regards,
-- 
Matthias Fend <matthias.fend@emfend.at>

Re: [PATCH 0/3] media: allegro: fixes and improvements

Posted by Nicolas Dufresne 4 months, 1 week ago

Hi Mathias,

Le lundi 01 septembre 2025 à 17:13 +0200, Matthias Fend a écrit :
> Several fixes and improvements for the Allegro DVT video IP encoder.
> These relate to race conditions that occur when multiple streams are used
> simultaneously.
> The problems could be reproduced on a ZCU-104 eval board with VCU firmware
> version 2019.2 on various kernel versions (6.4, 6.12 and 6.16).
> It is highly likely that these problems can also occur with other firmware
> versions.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
> ---
> Matthias Fend (3):
>       media: allegro: print warning if channel creation timeout occurs
>       media: allegro: process all pending status mbox messages
>       media: allegro: fix race conditions in channel handling
> 
>  drivers/media/platform/allegro-dvt/allegro-core.c | 114 +++++++++++++++++----
> -
>  1 file changed, 91 insertions(+), 23 deletions(-)
> ---
> base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0

For future submission, base your code on current media-commiters/next not on
current Linus RC (this one is rc-4 I believe).

regards,
Nicolas

> change-id: 20250901-allegro-dvt-fixes-932f2c97063e
> 
> Best regards,

Re: [PATCH 0/3] media: allegro: fixes and improvements

Posted by Nicolas Dufresne 4 months, 1 week ago

Hi,

Le lundi 01 septembre 2025 à 17:13 +0200, Matthias Fend a écrit :
> Several fixes and improvements for the Allegro DVT video IP encoder.
> These relate to race conditions that occur when multiple streams are used
> simultaneously.
> The problems could be reproduced on a ZCU-104 eval board with VCU firmware
> version 2019.2 on various kernel versions (6.4, 6.12 and 6.16).
> It is highly likely that these problems can also occur with other firmware
> versions.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
> ---
> Matthias Fend (3):
>       media: allegro: print warning if channel creation timeout occurs
>       media: allegro: process all pending status mbox messages
>       media: allegro: fix race conditions in channel handling


For the series:

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

>  drivers/media/platform/allegro-dvt/allegro-core.c | 114 +++++++++++++++++----
> -
>  1 file changed, 91 insertions(+), 23 deletions(-)
> ---
> base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0
> change-id: 20250901-allegro-dvt-fixes-932f2c97063e
> 
> Best regards,