Documentation/dev-tools/autofdo.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Use cat /proc/cpuinfo as opposed cat proc/cpuinfo.
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
Documentation/dev-tools/autofdo.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/dev-tools/autofdo.rst b/Documentation/dev-tools/autofdo.rst
index 1f0a451e9ccd..bcf06e7d6ffa 100644
--- a/Documentation/dev-tools/autofdo.rst
+++ b/Documentation/dev-tools/autofdo.rst
@@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel:
For Zen3::
- $ cat proc/cpuinfo | grep " brs"
+ $ cat /proc/cpuinfo | grep " brs"
For Zen4::
- $ cat proc/cpuinfo | grep amd_lbr_v2
+ $ cat /proc/cpuinfo | grep amd_lbr_v2
The following command generated the perf data file::
--
2.50.1
Hi Harshit, On Mon, 1 Sept 2025 at 17:57, Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > Use cat /proc/cpuinfo as opposed cat proc/cpuinfo. > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Thanks for your patch! > --- a/Documentation/dev-tools/autofdo.rst > +++ b/Documentation/dev-tools/autofdo.rst > @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel: > > For Zen3:: > > - $ cat proc/cpuinfo | grep " brs" > + $ cat /proc/cpuinfo | grep " brs" > > For Zen4:: > > - $ cat proc/cpuinfo | grep amd_lbr_v2 > + $ cat /proc/cpuinfo | grep amd_lbr_v2 > > The following command generated the perf data file:: > One might say the path depends on where the proc filesystem is mounted ;-) However, all other documentation (except for two occurrences in Documentation/networking/proc_net_tcp.rst, which you may want to fix, too) assumes /proc, so it is better to be consistent. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On 02/09/25 12:43, Geert Uytterhoeven wrote: > Hi Harshit, > > On Mon, 1 Sept 2025 at 17:57, Harshit Mogalapalli > <harshit.m.mogalapalli@oracle.com> wrote: >> Use cat /proc/cpuinfo as opposed cat proc/cpuinfo. >> >> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > > Thanks for your patch! > >> --- a/Documentation/dev-tools/autofdo.rst >> +++ b/Documentation/dev-tools/autofdo.rst >> @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel: >> >> For Zen3:: >> >> - $ cat proc/cpuinfo | grep " brs" >> + $ cat /proc/cpuinfo | grep " brs" >> >> For Zen4:: >> >> - $ cat proc/cpuinfo | grep amd_lbr_v2 >> + $ cat /proc/cpuinfo | grep amd_lbr_v2 >> >> The following command generated the perf data file:: >> > > One might say the path depends on where the proc filesystem is mounted ;-) > However, all other documentation (except for two occurrences in > Documentation/networking/proc_net_tcp.rst, which you may want to fix, > too) assumes /proc, so it is better to be consistent. > Oh very good point, yes I did check other instances and thought we make it consistent. > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Thanks a lot for the review. Regards, Harshit > Gr{oetje,eeting}s, > > Geert >
Thanks for the fix! I meant to include "/" in the original patch, but I overlooked it. Reviewed-by: Rong Xu <xur@google.com> On Tue, Sep 2, 2025 at 6:03 AM Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > > Hi Geert, > > On 02/09/25 12:43, Geert Uytterhoeven wrote: > > Hi Harshit, > > > > On Mon, 1 Sept 2025 at 17:57, Harshit Mogalapalli > > <harshit.m.mogalapalli@oracle.com> wrote: > >> Use cat /proc/cpuinfo as opposed cat proc/cpuinfo. > >> > >> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > > > > Thanks for your patch! > > > >> --- a/Documentation/dev-tools/autofdo.rst > >> +++ b/Documentation/dev-tools/autofdo.rst > >> @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel: > >> > >> For Zen3:: > >> > >> - $ cat proc/cpuinfo | grep " brs" > >> + $ cat /proc/cpuinfo | grep " brs" > >> > >> For Zen4:: > >> > >> - $ cat proc/cpuinfo | grep amd_lbr_v2 > >> + $ cat /proc/cpuinfo | grep amd_lbr_v2 > >> > >> The following command generated the perf data file:: > >> > > > > One might say the path depends on where the proc filesystem is mounted ;-) > > However, all other documentation (except for two occurrences in > > Documentation/networking/proc_net_tcp.rst, which you may want to fix, > > too) assumes /proc, so it is better to be consistent. > > > > Oh very good point, yes I did check other instances and thought we make > it consistent. > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thanks a lot for the review. > > > Regards, > Harshit > > > Gr{oetje,eeting}s, > > > > Geert > > >
Hi, On 31/08/25 20:37, Harshit Mogalapalli wrote: > Use cat /proc/cpuinfo as opposed cat proc/cpuinfo. > Please ignore this, I had a typo in my commit message for a typo fix :( Send a V2: https://lore.kernel.org/all/20250831151118.1274826-1-harshit.m.mogalapalli@oracle.com/ Thanks, Harshit> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > Documentation/dev-tools/autofdo.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/dev-tools/autofdo.rst b/Documentation/dev-tools/autofdo.rst > index 1f0a451e9ccd..bcf06e7d6ffa 100644 > --- a/Documentation/dev-tools/autofdo.rst > +++ b/Documentation/dev-tools/autofdo.rst > @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel: > > For Zen3:: > > - $ cat proc/cpuinfo | grep " brs" > + $ cat /proc/cpuinfo | grep " brs" > > For Zen4:: > > - $ cat proc/cpuinfo | grep amd_lbr_v2 > + $ cat /proc/cpuinfo | grep amd_lbr_v2 > > The following command generated the perf data file:: >
© 2016 - 2025 Red Hat, Inc.