[PATCH 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block

Denzeel Oliva posted 3 patches 1 month ago
There is a newer version of this series
[PATCH 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
Posted by Denzeel Oliva 1 month ago
Add the missing LHS_ACEL clock ID for the HSI0 block. This clock is
required for proper USB operation, as without it, USB connections fail
with errors like device descriptor read timeouts and address response
issues.

Fixes: 5feae3e79dbe ("dt-bindings: clock: samsung: Add Exynos990 SoC CMU bindings")
Cc: stable@vger.kernel.org
Signed-off-by: Denzeel Oliva <wachiturroxd150@gmail.com>
---
 include/dt-bindings/clock/samsung,exynos990.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/samsung,exynos990.h b/include/dt-bindings/clock/samsung,exynos990.h
index c5c79e078f2f60fdb2c0f61ba6e7f3c6f2fbe9f2..c60f15503d5b18b11ca9bdce86466512dc933901 100644
--- a/include/dt-bindings/clock/samsung,exynos990.h
+++ b/include/dt-bindings/clock/samsung,exynos990.h
@@ -236,6 +236,7 @@
 #define CLK_GOUT_HSI0_VGEN_LITE_HSI0_CLK		20
 #define CLK_GOUT_HSI0_CMU_HSI0_PCLK			21
 #define CLK_GOUT_HSI0_XIU_D_HSI0_ACLK			22
+#define CLK_GOUT_HSI0_LHS_ACEL_D_HSI0_CLK		23
 
 /* CMU_PERIS */
 #define CLK_MOUT_PERIS_BUS_USER			1

-- 
2.50.1
Re: [PATCH 1/3] dt-bindings: clock: exynos990: Add LHS_ACEL clock ID for HSI0 block
Posted by Krzysztof Kozlowski 1 month ago
On 31/08/2025 13:36, Denzeel Oliva wrote:
> Add the missing LHS_ACEL clock ID for the HSI0 block. This clock is
> required for proper USB operation, as without it, USB connections fail
> with errors like device descriptor read timeouts and address response
> issues.

Incomplete feature due to missing clock is not really a fix, considering
that we add clocks piece-by-piece. Otherwise every new clock would be a fix.

Unless something else changed and the USB was working fine before?

If not, drop fixes and cc-stable from this and following commits.

> 
> Fixes: 5feae3e79dbe ("dt-bindings: clock: samsung: Add Exynos990 SoC CMU bindings")
> Cc: stable@vger.kernel.org
> Signed-off-by: Denzeel Oliva <wachiturroxd150@gmail.com>
> ---
>  include/dt-bindings/clock/samsung,exynos990.h | 1 +
Best regards,
Krzysztof