[v1] starqltechn: fix max77705 device irqs

[PATCH 1/2] dt-bindings: add mfd/max77705 definitions

Posted by Dzmitry Sankouski 1 month ago

Add a dt-bindings include file for max77705 devicetree definition, define
available irq numbers.

Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
 MAINTAINERS                        |  1 +
 include/dt-bindings/mfd/max77705.h | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 020d7aa13188..82f500cf3c02 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15166,6 +15166,7 @@ F:	drivers/clk/clk-max77686.c
 F:	drivers/extcon/extcon-max14577.c
 F:	drivers/extcon/extcon-max77693.c
 F:	drivers/rtc/rtc-max77686.c
+F:	include/dt-bindings/mfd/max77705.h
 F:	include/linux/mfd/max14577*.h
 F:	include/linux/mfd/max77686*.h
 F:	include/linux/mfd/max77693*.h
diff --git a/include/dt-bindings/mfd/max77705.h b/include/dt-bindings/mfd/max77705.h
new file mode 100644
index 000000000000..34fcf1642e2d
--- /dev/null
+++ b/include/dt-bindings/mfd/max77705.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * DTS binding definitions used for the MAX77705 PMIC.
+ *
+ * Copyright (C) 2025 Dzmitry Sankouski <dsankouski@gmail.com>
+ */
+
+#ifndef _DT_BINDINGS_MFD_MAX77705_H
+#define _DT_BINDINGS_MFD_MAX77705_H
+
+#define MAX77705_IRQ_CHG	0
+#define MAX77705_IRQ_TOP	1
+#define MAX77705_IRQ_FG		2
+#define MAX77705_IRQ_USBC	3
+
+#endif

-- 
2.39.5

Re: [PATCH 1/2] dt-bindings: add mfd/max77705 definitions

Posted by Dmitry Baryshkov 1 month ago

On Sun, Aug 31, 2025 at 01:21:21AM +0300, Dzmitry Sankouski wrote:
> Add a dt-bindings include file for max77705 devicetree definition, define
> available irq numbers.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
>  MAINTAINERS                        |  1 +
>  include/dt-bindings/mfd/max77705.h | 16 ++++++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 020d7aa13188..82f500cf3c02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15166,6 +15166,7 @@ F:	drivers/clk/clk-max77686.c
>  F:	drivers/extcon/extcon-max14577.c
>  F:	drivers/extcon/extcon-max77693.c
>  F:	drivers/rtc/rtc-max77686.c
> +F:	include/dt-bindings/mfd/max77705.h
>  F:	include/linux/mfd/max14577*.h
>  F:	include/linux/mfd/max77686*.h
>  F:	include/linux/mfd/max77693*.h
> diff --git a/include/dt-bindings/mfd/max77705.h b/include/dt-bindings/mfd/max77705.h
> new file mode 100644
> index 000000000000..34fcf1642e2d
> --- /dev/null
> +++ b/include/dt-bindings/mfd/max77705.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * DTS binding definitions used for the MAX77705 PMIC.
> + *
> + * Copyright (C) 2025 Dzmitry Sankouski <dsankouski@gmail.com>
> + */
> +
> +#ifndef _DT_BINDINGS_MFD_MAX77705_H
> +#define _DT_BINDINGS_MFD_MAX77705_H
> +
> +#define MAX77705_IRQ_CHG	0
> +#define MAX77705_IRQ_TOP	1
> +#define MAX77705_IRQ_FG		2
> +#define MAX77705_IRQ_USBC	3

There is usually no need to define IRQs as bindings.

> +
> +#endif
> 
> -- 
> 2.39.5
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] dt-bindings: add mfd/max77705 definitions

Posted by Krzysztof Kozlowski 1 month ago

On 31/08/2025 12:05, Dmitry Baryshkov wrote:
> On Sun, Aug 31, 2025 at 01:21:21AM +0300, Dzmitry Sankouski wrote:
>> +
>> +#ifndef _DT_BINDINGS_MFD_MAX77705_H
>> +#define _DT_BINDINGS_MFD_MAX77705_H
>> +
>> +#define MAX77705_IRQ_CHG	0
>> +#define MAX77705_IRQ_TOP	1
>> +#define MAX77705_IRQ_FG		2
>> +#define MAX77705_IRQ_USBC	3
> 
> There is usually no need to define IRQs as bindings.

Yeah, that's not really a binding.

Best regards,
Krzysztof