[PATCH] ARM: dts: kirkwood: Fix sound DAI cells for OpenRD clients

Jihed Chaibi posted 1 patch 1 month ago
arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ARM: dts: kirkwood: Fix sound DAI cells for OpenRD clients
Posted by Jihed Chaibi 1 month ago
A previous commit changed the '#sound-dai-cells' property for the
kirkwood audio controller from 1 to 0 in the kirkwood.dtsi file,
but did not update the corresponding 'sound-dai' property in the
kirkwood-openrd-client.dts file.

This created a mismatch, causing a dtbs_check validation error where
the dts provides one cell (<&audio0 0>) while the .dtsi expects zero.

Remove the extraneous cell from the 'sound-dai' property to fix the
schema validation warning and align with the updated binding.

Fixes: e662e70fa419 ("arm: dts: kirkwood: fix error in #sound-dai-cells size")
Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts b/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
index d4e0b8150a8..cf26e2ceaaa 100644
--- a/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
+++ b/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
@@ -38,7 +38,7 @@ sound {
 		simple-audio-card,mclk-fs = <256>;
 
 		simple-audio-card,cpu {
-			sound-dai = <&audio0 0>;
+			sound-dai = <&audio0>;
 		};
 
 		simple-audio-card,codec {
-- 
2.39.5
Re: [PATCH] ARM: dts: kirkwood: Fix sound DAI cells for OpenRD clients
Posted by Gregory CLEMENT 3 weeks ago
Jihed Chaibi <jihed.chaibi.dev@gmail.com> writes:

> A previous commit changed the '#sound-dai-cells' property for the
> kirkwood audio controller from 1 to 0 in the kirkwood.dtsi file,
> but did not update the corresponding 'sound-dai' property in the
> kirkwood-openrd-client.dts file.
>
> This created a mismatch, causing a dtbs_check validation error where
> the dts provides one cell (<&audio0 0>) while the .dtsi expects zero.
>
> Remove the extraneous cell from the 'sound-dai' property to fix the
> schema validation warning and align with the updated binding.
>
> Fixes: e662e70fa419 ("arm: dts: kirkwood: fix error in #sound-dai-cells size")
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>

Applied on mvebu/fixes

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts b/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
> index d4e0b8150a8..cf26e2ceaaa 100644
> --- a/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
> +++ b/arch/arm/boot/dts/marvell/kirkwood-openrd-client.dts
> @@ -38,7 +38,7 @@ sound {
>  		simple-audio-card,mclk-fs = <256>;
>  
>  		simple-audio-card,cpu {
> -			sound-dai = <&audio0 0>;
> +			sound-dai = <&audio0>;
>  		};
>  
>  		simple-audio-card,codec {
> -- 
> 2.39.5
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH] ARM: dts: kirkwood: Fix sound DAI cells for OpenRD clients
Posted by Krzysztof Kozlowski 1 month ago
On 30/08/2025 22:37, Jihed Chaibi wrote:
> A previous commit changed the '#sound-dai-cells' property for the
> kirkwood audio controller from 1 to 0 in the kirkwood.dtsi file,
> but did not update the corresponding 'sound-dai' property in the
> kirkwood-openrd-client.dts file.
> 
> This created a mismatch, causing a dtbs_check validation error where
> the dts provides one cell (<&audio0 0>) while the .dtsi expects zero.
> 
> Remove the extraneous cell from the 'sound-dai' property to fix the
> schema validation warning and align with the updated binding.
> 
> Fixes: e662e70fa419 ("arm: dts: kirkwood: fix error in #sound-dai-cells size")
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof