[PATCH v4 0/2] Pinefeat cef168 lens control board driver

Aliaksandr Smirnou posted 2 patches 1 month ago
.../bindings/media/i2c/pinefeat,cef168.yaml   |  47 +++
.../devicetree/bindings/vendor-prefixes.yaml  |   2 +
MAINTAINERS                                   |   7 +
drivers/media/i2c/Kconfig                     |   9 +
drivers/media/i2c/Makefile                    |   1 +
drivers/media/i2c/cef168.c                    | 331 ++++++++++++++++++
include/uapi/linux/v4l2-controls.h            |   6 +
7 files changed, 403 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
create mode 100644 drivers/media/i2c/cef168.c
[PATCH v4 0/2] Pinefeat cef168 lens control board driver
Posted by Aliaksandr Smirnou 1 month ago
This patch series adds support for the Pinefeat adapter, which interfaces
Canon EF and EF-S lenses to non-Canon camera bodies. The cef168 circuit
control board provides an I2C interface for electronic focus and aperture
control. The driver integrates with the V4L2 sub-device API.

For more information about the product, see:
https://github.com/pinefeat/cef168

Changes in v4:
 - removed driver mention from the hardware documentation;
 - added named email in commit signed-off-by;
 - added select CRC8 in Kconfig;
 - removed header file;
 - moved variable declaration at the beginning of the function;
 - removed kerneldoc from structures;
 - removed control id check as the core handles this for us;
 - removed Power Management Runtime (pm_runtime_*) calls as redundant;
 - reserved v4l2 controls in linux header file;

Link to v3: https://lore.kernel.org/all/20250817130549.7766-1-support@pinefeat.co.uk/

Patches:
  dt-bindings: Pinefeat cef168 lens control board
  media: i2c: Pinefeat cef168 lens control board driver

 .../bindings/media/i2c/pinefeat,cef168.yaml   |  47 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   7 +
 drivers/media/i2c/Kconfig                     |   9 +
 drivers/media/i2c/Makefile                    |   1 +
 drivers/media/i2c/cef168.c                    | 331 ++++++++++++++++++
 include/uapi/linux/v4l2-controls.h            |   6 +
 7 files changed, 403 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/pinefeat,cef168.yaml
 create mode 100644 drivers/media/i2c/cef168.c


base-commit: 2b38afce25c4e1b8f943ff4f0a2b51d6c40f2ed2
-- 
2.34.1
Re: [PATCH v4 0/2] Pinefeat cef168 lens control board driver
Posted by Krzysztof Kozlowski 1 month ago
On 30/08/2025 13:14, Aliaksandr Smirnou wrote:
> This patch series adds support for the Pinefeat adapter, which interfaces
> Canon EF and EF-S lenses to non-Canon camera bodies. The cef168 circuit
> control board provides an I2C interface for electronic focus and aperture
> control. The driver integrates with the V4L2 sub-device API.
> 
> For more information about the product, see:
> https://github.com/pinefeat/cef168
> 
> Changes in v4:

You already sent v4, so this makes a duplicate posting messing up with
tools.

https://lore.kernel.org/all/20250824-cuddly-cryptic-porpoise-b66b4a@kuoka/

Each posting is its own version. Resending - not marked here as resend -
would be sending the same patch.

Best regards,
Krzysztof
Re: [PATCH v4 0/2] Pinefeat cef168 lens control board driver
Posted by Aliaksandr Smirnou 1 week, 4 days ago
On Sat, 30 Aug 2025 15:20:30 +0200, Krzysztof Kozlowski wrote:
> > This patch series adds support for the Pinefeat adapter, which interfaces
> > Canon EF and EF-S lenses to non-Canon camera bodies. The cef168 circuit
> > control board provides an I2C interface for electronic focus and aperture
> > control. The driver integrates with the V4L2 sub-device API.
> > 
> > For more information about the product, see:
> > https://github.com/pinefeat/cef168
> > 
> > Changes in v4:
> 
> You already sent v4, so this makes a duplicate posting messing up with
> tools.
> 
> https://lore.kernel.org/all/20250824-cuddly-cryptic-porpoise-b66b4a@kuoka/
> 
> Each posting is its own version. Resending - not marked here as resend -
> would be sending the same patch.

Gentle ping.

This is still v4; the only difference was correcting the sender address.
No functional changes since v4. I'm keeping this as v4 unless you prefer a
rebase.