[PATCH] hwmon: (nct6775) Use int type to store negative error codes

Qianfeng Rong posted 1 patch 1 month ago
drivers/hwmon/nct6775-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] hwmon: (nct6775) Use int type to store negative error codes
Posted by Qianfeng Rong 1 month ago
Change the 'ret' variable from u32 to int in nct6775_asuswmi_read() to
store negative error codes or zero;

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
 drivers/hwmon/nct6775-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index 0a040364b512..407945d2cd6a 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -167,7 +167,8 @@ static inline int nct6775_asuswmi_write(u8 bank, u8 reg, u8 val)
 
 static inline int nct6775_asuswmi_read(u8 bank, u8 reg, u8 *val)
 {
-	u32 ret, tmp = 0;
+	u32 tmp = 0;
+	int ret;
 
 	ret = nct6775_asuswmi_evaluate_method(ASUSWMI_METHODID_RHWM, bank,
 					      reg, 0, &tmp);
-- 
2.34.1
Re: [PATCH] hwmon: (nct6775) Use int type to store negative error codes
Posted by Guenter Roeck 1 month ago
On Sat, Aug 30, 2025 at 05:51:05PM +0800, Qianfeng Rong wrote:
> Change the 'ret' variable from u32 to int in nct6775_asuswmi_read() to
> store negative error codes or zero;
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
> 
> No effect on runtime.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>

Applied.

Guenter