[PATCH v3 03/14] rust: drm: gem: Drop Object::SIZE

Lyude Paul posted 14 patches 1 month ago
[PATCH v3 03/14] rust: drm: gem: Drop Object::SIZE
Posted by Lyude Paul 1 month ago
Drive-by fix, it doesn't seem like anything actually uses this constant
anymore.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/kernel/drm/gem/mod.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs
index 80940ed11368d..b27b9fbf28bbb 100644
--- a/rust/kernel/drm/gem/mod.rs
+++ b/rust/kernel/drm/gem/mod.rs
@@ -12,7 +12,7 @@
     prelude::*,
     types::{ARef, AlwaysRefCounted, Opaque},
 };
-use core::{mem, ops::Deref, ptr::NonNull};
+use core::{ops::Deref, ptr::NonNull};
 
 /// A type alias for retrieving a [`Driver`]s [`DriverFile`] implementation from its
 /// [`DriverObject`] implementation.
@@ -197,9 +197,6 @@ pub struct Object<T: DriverObject + Send + Sync> {
 }
 
 impl<T: DriverObject> Object<T> {
-    /// The size of this object's structure.
-    pub const SIZE: usize = mem::size_of::<Self>();
-
     const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs {
         free: Some(Self::free_callback),
         open: Some(open_callback::<T>),
-- 
2.50.0
Re: [PATCH v3 03/14] rust: drm: gem: Drop Object::SIZE
Posted by Daniel Almeida 4 weeks, 1 day ago

> On 29 Aug 2025, at 19:35, Lyude Paul <lyude@redhat.com> wrote:
> 
> Drive-by fix, it doesn't seem like anything actually uses this constant
> anymore.
> 
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Reviewed-by: Danilo Krummrich <dakr@kernel.org>
> ---
> rust/kernel/drm/gem/mod.rs | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs
> index 80940ed11368d..b27b9fbf28bbb 100644
> --- a/rust/kernel/drm/gem/mod.rs
> +++ b/rust/kernel/drm/gem/mod.rs
> @@ -12,7 +12,7 @@
>     prelude::*,
>     types::{ARef, AlwaysRefCounted, Opaque},
> };
> -use core::{mem, ops::Deref, ptr::NonNull};
> +use core::{ops::Deref, ptr::NonNull};
> 
> /// A type alias for retrieving a [`Driver`]s [`DriverFile`] implementation from its
> /// [`DriverObject`] implementation.
> @@ -197,9 +197,6 @@ pub struct Object<T: DriverObject + Send + Sync> {
> }
> 
> impl<T: DriverObject> Object<T> {
> -    /// The size of this object's structure.
> -    pub const SIZE: usize = mem::size_of::<Self>();
> -
>     const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs {
>         free: Some(Self::free_callback),
>         open: Some(open_callback::<T>),
> -- 
> 2.50.0
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>