[PATCH v3 0/4] cxl, acpi/hmat, node: Update CXL access coordinates to node directly

Dave Jiang posted 4 patches 1 month ago
drivers/acpi/numa/hmat.c  | 34 ----------------------------------
drivers/base/node.c       | 38 ++++++++++++++++++++++++++++++++++++++
drivers/cxl/core/cdat.c   | 11 -----------
drivers/cxl/core/core.h   |  3 ---
drivers/cxl/core/region.c | 20 ++++++++++++--------
include/linux/acpi.h      | 12 ------------
include/linux/memory.h    |  6 +++---
include/linux/node.h      |  8 ++++++++
8 files changed, 61 insertions(+), 71 deletions(-)
[PATCH v3 0/4] cxl, acpi/hmat, node: Update CXL access coordinates to node directly
Posted by Dave Jiang 1 month ago
I plan to take this series through the CXL tree when all the necessary tags
are received.

Rafael, please ack patches 3/4 and 4/4 if you are happy with the changes.

Thank you!

v3:
- Fix grammar in comment. (DavidH)
- Use nodemask instead of xarray. (Jonathan)

v2:
- Use clearer comment from DavidH for 1/4. (DavidH)
- Fix comment in 2/4. (DavidH)
- Streamline code in 2/4. (DavidH)
- Add description to observed issue. (Dan)
- Add correct Fixes tag. (Dan)
- Add cc to stable for fix patch. (Dan)
- Add mechansim to only update on first region for the node. (Jonathan)

The series aim to clean up the current CXL memory region hotplug notifier by
removing the update path through HMAT and updating the node access coordinates
directly. With the existing implementation, the CXL memory hotplug notifier
gets called first. It updates the HMAT target access coordinates. And then
the HMAT notifier gets called and create the node sysfs attribs. The new
implemenation flips the callback ordering and directly updates the sysfs
attribs already created in the node and leaves HMAT data structures alone.

Dave Jiang (4):
  mm/memory_hotplug: Update comment for hotplug memory callback
    priorities
  drivers/base/node: Add a helper function node_update_perf_attrs()
  cxl, acpi/hmat: Update CXL access coordinates directly instead of
    through HMAT
  acpi/hmat: Remove now unused hmat_update_target_coordinates()

 drivers/acpi/numa/hmat.c  | 34 ----------------------------------
 drivers/base/node.c       | 38 ++++++++++++++++++++++++++++++++++++++
 drivers/cxl/core/cdat.c   | 11 -----------
 drivers/cxl/core/core.h   |  3 ---
 drivers/cxl/core/region.c | 20 ++++++++++++--------
 include/linux/acpi.h      | 12 ------------
 include/linux/memory.h    |  6 +++---
 include/linux/node.h      |  8 ++++++++
 8 files changed, 61 insertions(+), 71 deletions(-)


base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
-- 
2.50.1
Re: [PATCH v3 0/4] cxl, acpi/hmat, node: Update CXL access coordinates to node directly
Posted by Dave Jiang 1 month ago

On 8/29/25 3:29 PM, Dave Jiang wrote:
> I plan to take this series through the CXL tree when all the necessary tags
> are received.
> 
> Rafael, please ack patches 3/4 and 4/4 if you are happy with the changes.
> 
> Thank you!

Rafael said Dan's review tag is sufficient.

Applied to cxl/next
02f6c6a3654911e286ae04e5dfd5deb0f39559b1

> 
> v3:
> - Fix grammar in comment. (DavidH)
> - Use nodemask instead of xarray. (Jonathan)
> 
> v2:
> - Use clearer comment from DavidH for 1/4. (DavidH)
> - Fix comment in 2/4. (DavidH)
> - Streamline code in 2/4. (DavidH)
> - Add description to observed issue. (Dan)
> - Add correct Fixes tag. (Dan)
> - Add cc to stable for fix patch. (Dan)
> - Add mechansim to only update on first region for the node. (Jonathan)
> 
> The series aim to clean up the current CXL memory region hotplug notifier by
> removing the update path through HMAT and updating the node access coordinates
> directly. With the existing implementation, the CXL memory hotplug notifier
> gets called first. It updates the HMAT target access coordinates. And then
> the HMAT notifier gets called and create the node sysfs attribs. The new
> implemenation flips the callback ordering and directly updates the sysfs
> attribs already created in the node and leaves HMAT data structures alone.
> 
> Dave Jiang (4):
>   mm/memory_hotplug: Update comment for hotplug memory callback
>     priorities
>   drivers/base/node: Add a helper function node_update_perf_attrs()
>   cxl, acpi/hmat: Update CXL access coordinates directly instead of
>     through HMAT
>   acpi/hmat: Remove now unused hmat_update_target_coordinates()
> 
>  drivers/acpi/numa/hmat.c  | 34 ----------------------------------
>  drivers/base/node.c       | 38 ++++++++++++++++++++++++++++++++++++++
>  drivers/cxl/core/cdat.c   | 11 -----------
>  drivers/cxl/core/core.h   |  3 ---
>  drivers/cxl/core/region.c | 20 ++++++++++++--------
>  include/linux/acpi.h      | 12 ------------
>  include/linux/memory.h    |  6 +++---
>  include/linux/node.h      |  8 ++++++++
>  8 files changed, 61 insertions(+), 71 deletions(-)
> 
> 
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585