drivers/misc/amd-sbi/Kconfig | 1 + 1 file changed, 1 insertion(+)
Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct
regmap_config is not defined:
drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’:
drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type
57 | struct regmap_config sbrmi_i2c_regmap_config = {
| ^~~~~~~~~~~~~
Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c():
ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe':
drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c'
Fixes: 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem")
Cc: stable@vger.kernel.org
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
drivers/misc/amd-sbi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/amd-sbi/Kconfig b/drivers/misc/amd-sbi/Kconfig
index 4840831c84ca..4aae0733d0fc 100644
--- a/drivers/misc/amd-sbi/Kconfig
+++ b/drivers/misc/amd-sbi/Kconfig
@@ -2,6 +2,7 @@
config AMD_SBRMI_I2C
tristate "AMD side band RMI support"
depends on I2C
+ select REGMAP_I2C
help
Side band RMI over I2C support for AMD out of band management.
--
2.47.2
On 8/29/2025 2:44 PM, Max Kellermann wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct > regmap_config is not defined: > > drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’: > drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type > 57 | struct regmap_config sbrmi_i2c_regmap_config = { > | ^~~~~~~~~~~~~ > > Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c(): > > ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe': > drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c' > > Fixes: 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem") > Cc: stable@vger.kernel.org > Signed-off-by: Max Kellermann <max.kellermann@ionos.com> > --- > drivers/misc/amd-sbi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/amd-sbi/Kconfig b/drivers/misc/amd-sbi/Kconfig > index 4840831c84ca..4aae0733d0fc 100644 > --- a/drivers/misc/amd-sbi/Kconfig > +++ b/drivers/misc/amd-sbi/Kconfig > @@ -2,6 +2,7 @@ > config AMD_SBRMI_I2C > tristate "AMD side band RMI support" > depends on I2C > + select REGMAP_I2C > help > Side band RMI over I2C support for AMD out of band management. > > -- > 2.47.2 Thank you for the patch. Tested-by: Akshay Gupta <Akshay.Gupta@amd.com> Reviewed-by: Akshay Gupta <Akshay.Gupta@amd.com>
© 2016 - 2025 Red Hat, Inc.