panic: use angle-bracket include for panic.h

[PATCH] panic: use angle-bracket include for panic.h

Posted by Jinchao Wang 1 month ago

Replace quoted includes of panic.h with `#include <linux/panic.h>` for
consistency across the kernel.

Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
---
 kernel/crash_core.c    | 2 +-
 kernel/printk/nbcon.c  | 2 +-
 kernel/printk/printk.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index bb38bbaf3a26..a5e8523dd6eb 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -4,7 +4,6 @@
  * Copyright (C) 2002-2004 Eric Biederman  <ebiederm@xmission.com>
  */
 
-#include "linux/panic.h"
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/buildid.h>
@@ -23,6 +22,7 @@
 #include <linux/btf.h>
 #include <linux/objtool.h>
 #include <linux/delay.h>
+#include <linux/panic.h>
 
 #include <asm/page.h>
 #include <asm/sections.h>
diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
index 171480135830..558ef3177976 100644
--- a/kernel/printk/nbcon.c
+++ b/kernel/printk/nbcon.c
@@ -2,7 +2,6 @@
 // Copyright (C) 2022 Linutronix GmbH, John Ogness
 // Copyright (C) 2022 Intel, Thomas Gleixner
 
-#include "linux/panic.h"
 #include <linux/atomic.h>
 #include <linux/bug.h>
 #include <linux/console.h>
@@ -13,6 +12,7 @@
 #include <linux/irqflags.h>
 #include <linux/kthread.h>
 #include <linux/minmax.h>
+#include <linux/panic.h>
 #include <linux/percpu.h>
 #include <linux/preempt.h>
 #include <linux/slab.h>
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 236f03937107..5aee9ffb16b9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -17,7 +17,6 @@
  *	01Mar01 Andrew Morton
  */
 
-#include "linux/panic.h"
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/kernel.h>
@@ -49,6 +48,7 @@
 #include <linux/sched/clock.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task_stack.h>
+#include <linux/panic.h>
 
 #include <linux/uaccess.h>
 #include <asm/sections.h>
-- 
2.43.0

Re: [PATCH] panic: use angle-bracket include for panic.h

Posted by John Ogness 1 month ago

Added CC printk folks...

On 2025-08-29, Jinchao Wang <wangjinchao600@gmail.com> wrote:
> Replace quoted includes of panic.h with `#include <linux/panic.h>` for
> consistency across the kernel.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>

Reviewed-by: John Ogness <john.ogness@linutronix.de>

> ---
>  kernel/crash_core.c    | 2 +-
>  kernel/printk/nbcon.c  | 2 +-
>  kernel/printk/printk.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index bb38bbaf3a26..a5e8523dd6eb 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -4,7 +4,6 @@
>   * Copyright (C) 2002-2004 Eric Biederman  <ebiederm@xmission.com>
>   */
>  
> -#include "linux/panic.h"
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/buildid.h>
> @@ -23,6 +22,7 @@
>  #include <linux/btf.h>
>  #include <linux/objtool.h>
>  #include <linux/delay.h>
> +#include <linux/panic.h>
>  
>  #include <asm/page.h>
>  #include <asm/sections.h>
> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
> index 171480135830..558ef3177976 100644
> --- a/kernel/printk/nbcon.c
> +++ b/kernel/printk/nbcon.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2022 Linutronix GmbH, John Ogness
>  // Copyright (C) 2022 Intel, Thomas Gleixner
>  
> -#include "linux/panic.h"
>  #include <linux/atomic.h>
>  #include <linux/bug.h>
>  #include <linux/console.h>
> @@ -13,6 +12,7 @@
>  #include <linux/irqflags.h>
>  #include <linux/kthread.h>
>  #include <linux/minmax.h>
> +#include <linux/panic.h>
>  #include <linux/percpu.h>
>  #include <linux/preempt.h>
>  #include <linux/slab.h>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 236f03937107..5aee9ffb16b9 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -17,7 +17,6 @@
>   *	01Mar01 Andrew Morton
>   */
>  
> -#include "linux/panic.h"
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/kernel.h>
> @@ -49,6 +48,7 @@
>  #include <linux/sched/clock.h>
>  #include <linux/sched/debug.h>
>  #include <linux/sched/task_stack.h>
> +#include <linux/panic.h>
>  
>  #include <linux/uaccess.h>
>  #include <asm/sections.h>
> -- 
> 2.43.0

Re: [PATCH] panic: use angle-bracket include for panic.h

Posted by Petr Mladek 1 month ago

On Fri 2025-08-29 09:40:41, John Ogness wrote:
> Added CC printk folks...

Thanks for adding me into Cc.

> On 2025-08-29, Jinchao Wang <wangjinchao600@gmail.com> wrote:
> > Replace quoted includes of panic.h with `#include <linux/panic.h>` for
> > consistency across the kernel.
> >
> > Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
> 
> Reviewed-by: John Ogness <john.ogness@linutronix.de>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Re: [PATCH] panic: use angle-bracket include for panic.h

Posted by Jinchao Wang 1 month ago

On 8/29/25 13:13, Jinchao Wang wrote:
> Replace quoted includes of panic.h with `#include <linux/panic.h>` for
> consistency across the kernel.
> 
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
> ---
>   kernel/crash_core.c    | 2 +-
>   kernel/printk/nbcon.c  | 2 +-
>   kernel/printk/printk.c | 2 +-
This patch is based on the mm-nonmm-unstable branch, where the previous
"panic status function family" series was merged.

-- 
Best regards,
Jinchao