1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add the support for SM8750 Video clock controller
  4. View patch

[PATCH v2 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller

Taniya Das posted 3 patches 1 month ago
[PATCH v2 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller
Posted by Taniya Das 1 month ago 
Add compatible string for SM8750 video clock controller and the bindings
for SM8750 Qualcomm SoC.

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/clock/qcom,sm8450-videocc.yaml        |  5 ++-
 include/dt-bindings/clock/qcom,sm8750-videocc.h    | 40 ++++++++++++++++++++++
 2 files changed, 44 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
index fcd2727dae46711650fc8fe71221a06630040026..b31bd833552937fa896f69966cfe5c79d9cfdd21 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Qualcomm Video Clock & Reset Controller on SM8450
 
 maintainers:
-  - Taniya Das <quic_tdas@quicinc.com>
+  - Taniya Das <taniya.das@oss.qualcomm.com>
   - Jagadeesh Kona <quic_jkona@quicinc.com>
 
 description: |
@@ -17,6 +17,7 @@ description: |
   See also:
     include/dt-bindings/clock/qcom,sm8450-videocc.h
     include/dt-bindings/clock/qcom,sm8650-videocc.h
+    include/dt-bindings/clock/qcom,sm8750-videocc.h
 
 properties:
   compatible:
@@ -25,6 +26,7 @@ properties:
       - qcom,sm8475-videocc
       - qcom,sm8550-videocc
       - qcom,sm8650-videocc
+      - qcom,sm8750-videocc
       - qcom,x1e80100-videocc
 
   clocks:
@@ -61,6 +63,7 @@ allOf:
             enum:
               - qcom,sm8450-videocc
               - qcom,sm8550-videocc
+              - qcom,sm8750-videocc
     then:
       required:
         - required-opps
diff --git a/include/dt-bindings/clock/qcom,sm8750-videocc.h b/include/dt-bindings/clock/qcom,sm8750-videocc.h
new file mode 100644
index 0000000000000000000000000000000000000000..f3bfa2ba51607d0133efcdad9c7729eb7a49b177
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,sm8750-videocc.h
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SM8750_H
+#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_SM8750_H
+
+/* VIDEO_CC clocks */
+#define VIDEO_CC_AHB_CLK					0
+#define VIDEO_CC_AHB_CLK_SRC					1
+#define VIDEO_CC_MVS0_CLK					2
+#define VIDEO_CC_MVS0_CLK_SRC					3
+#define VIDEO_CC_MVS0_DIV_CLK_SRC				4
+#define VIDEO_CC_MVS0_FREERUN_CLK				5
+#define VIDEO_CC_MVS0_SHIFT_CLK					6
+#define VIDEO_CC_MVS0C_CLK					7
+#define VIDEO_CC_MVS0C_DIV2_DIV_CLK_SRC				8
+#define VIDEO_CC_MVS0C_FREERUN_CLK				9
+#define VIDEO_CC_MVS0C_SHIFT_CLK				10
+#define VIDEO_CC_PLL0						11
+#define VIDEO_CC_SLEEP_CLK					12
+#define VIDEO_CC_SLEEP_CLK_SRC					13
+#define VIDEO_CC_XO_CLK						14
+#define VIDEO_CC_XO_CLK_SRC					15
+
+/* VIDEO_CC power domains */
+#define VIDEO_CC_MVS0_GDSC					0
+#define VIDEO_CC_MVS0C_GDSC					1
+
+/* VIDEO_CC resets */
+#define VIDEO_CC_INTERFACE_BCR					0
+#define VIDEO_CC_MVS0_BCR					1
+#define VIDEO_CC_MVS0C_CLK_ARES					2
+#define VIDEO_CC_MVS0C_BCR					3
+#define VIDEO_CC_MVS0_FREERUN_CLK_ARES				4
+#define VIDEO_CC_MVS0C_FREERUN_CLK_ARES				5
+#define VIDEO_CC_XO_CLK_ARES					6
+
+#endif

-- 
2.34.1
Re: [PATCH v2 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller
Posted by Bryan O'Donoghue 2 weeks, 4 days ago 
On 29/08/2025 11:15, Taniya Das wrote:
> Add compatible string for SM8750 video clock controller and the bindings
> for SM8750 Qualcomm SoC.
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   .../bindings/clock/qcom,sm8450-videocc.yaml        |  5 ++-
>   include/dt-bindings/clock/qcom,sm8750-videocc.h    | 40 ++++++++++++++++++++++
>   2 files changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index fcd2727dae46711650fc8fe71221a06630040026..b31bd833552937fa896f69966cfe5c79d9cfdd21 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   title: Qualcomm Video Clock & Reset Controller on SM8450
> 
>   maintainers:
> -  - Taniya Das <quic_tdas@quicinc.com>
> +  - Taniya Das <taniya.das@oss.qualcomm.com>
>     - Jagadeesh Kona <quic_jkona@quicinc.com>
> 
>   description: |
> @@ -17,6 +17,7 @@ description: |
>     See also:
>       include/dt-bindings/clock/qcom,sm8450-videocc.h
>       include/dt-bindings/clock/qcom,sm8650-videocc.h
> +    include/dt-bindings/clock/qcom,sm8750-videocc.h
> 
>   properties:
>     compatible:
> @@ -25,6 +26,7 @@ properties:
>         - qcom,sm8475-videocc
>         - qcom,sm8550-videocc
>         - qcom,sm8650-videocc
> +      - qcom,sm8750-videocc

Shouldn't this be qcom,pakala-videocc now ?

---
bod
Re: [PATCH v2 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller
Posted by Taniya Das 1 week ago 

On 9/15/2025 4:28 PM, Bryan O'Donoghue wrote:
> On 29/08/2025 11:15, Taniya Das wrote:
>> Add compatible string for SM8750 video clock controller and the bindings
>> for SM8750 Qualcomm SoC.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>>   .../bindings/clock/qcom,sm8450-videocc.yaml        |  5 ++-
>>   include/dt-bindings/clock/qcom,sm8750-videocc.h    | 40 ++++++++++++
>> ++++++++++
>>   2 files changed, 44 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-
>> videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-
>> videocc.yaml
>> index
>> fcd2727dae46711650fc8fe71221a06630040026..b31bd833552937fa896f69966cfe5c79d9cfdd21 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   title: Qualcomm Video Clock & Reset Controller on SM8450
>>
>>   maintainers:
>> -  - Taniya Das <quic_tdas@quicinc.com>
>> +  - Taniya Das <taniya.das@oss.qualcomm.com>
>>     - Jagadeesh Kona <quic_jkona@quicinc.com>
>>
>>   description: |
>> @@ -17,6 +17,7 @@ description: |
>>     See also:
>>       include/dt-bindings/clock/qcom,sm8450-videocc.h
>>       include/dt-bindings/clock/qcom,sm8650-videocc.h
>> +    include/dt-bindings/clock/qcom,sm8750-videocc.h
>>
>>   properties:
>>     compatible:
>> @@ -25,6 +26,7 @@ properties:
>>         - qcom,sm8475-videocc
>>         - qcom,sm8550-videocc
>>         - qcom,sm8650-videocc
>> +      - qcom,sm8750-videocc
> 
> Shouldn't this be qcom,pakala-videocc now ?
> 

As of now, Bryan, all of Pakala is using the SM8750. We can migrate
everything together to maintain consistency.


-- 
Thanks,
Taniya Das
Re: [PATCH v2 2/3] dt-bindings: clock: qcom: Add SM8750 video clock controller
Posted by Konrad Dybcio 1 week ago 
On 9/26/25 11:18 AM, Taniya Das wrote:
> 
> 
> On 9/15/2025 4:28 PM, Bryan O'Donoghue wrote:
>> On 29/08/2025 11:15, Taniya Das wrote:
>>> Add compatible string for SM8750 video clock controller and the bindings
>>> for SM8750 Qualcomm SoC.
>>>
>>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---

[...]

>>>   properties:
>>>     compatible:
>>> @@ -25,6 +26,7 @@ properties:
>>>         - qcom,sm8475-videocc
>>>         - qcom,sm8550-videocc
>>>         - qcom,sm8650-videocc
>>> +      - qcom,sm8750-videocc
>>
>> Shouldn't this be qcom,pakala-videocc now ?
>>
> 
> As of now, Bryan, all of Pakala is using the SM8750. We can migrate
> everything together to maintain consistency.

We settled on keeping new compatibles numerical for already-numerical
platforms (except board compatibles where all the fuss was / as it makes
sense)

Konrad

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.