Add a cell for the PMIC's onboard General Purpose ADC.

Signed-off-by: Duje Mihanović <duje@dujemihanovic.xyz>
---
 drivers/mfd/88pm886.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c
index 39dd9a818b0f0e1e5839f76768ff54940f4cefa5..dd7a563152e5f845b7d6cd2ed582577c322c91eb 100644
--- a/drivers/mfd/88pm886.c
+++ b/drivers/mfd/88pm886.c
@@ -38,6 +38,7 @@ static const struct mfd_cell pm886_devs[] = {
 	MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
 	MFD_CELL_NAME("88pm886-regulator"),
 	MFD_CELL_NAME("88pm886-rtc"),
+	MFD_CELL_NAME("88pm886-gpadc"),
 };
 
 static int pm886_power_off_handler(struct sys_off_data *sys_off_data)

-- 
2.51.0

On Fri, Aug 29, 2025 at 1:18 AM Duje Mihanović <duje@dujemihanovic.xyz> wrote:
>
> Add a cell for the PMIC's onboard General Purpose ADC.

...

>  static const struct mfd_cell pm886_devs[] = {

>         MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
>         MFD_CELL_NAME("88pm886-regulator"),
>         MFD_CELL_NAME("88pm886-rtc"),
> +       MFD_CELL_NAME("88pm886-gpadc"),

List seems ordered, please prevent it.

>  };


-- 
With Best Regards,
Andy Shevchenko

Andy Shevchenko, 2025-08-29T18:47:19+03:00:
> On Fri, Aug 29, 2025 at 1:18 AM Duje Mihanović <duje@dujemihanovic.xyz> wrote:
>>
>> Add a cell for the PMIC's onboard General Purpose ADC.
>
> ...
>
>>  static const struct mfd_cell pm886_devs[] = {
>
>>         MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
>>         MFD_CELL_NAME("88pm886-regulator"),
>>         MFD_CELL_NAME("88pm886-rtc"),
>> +       MFD_CELL_NAME("88pm886-gpadc"),
>
> List seems ordered, please prevent it.

Ah, I never explicitly realized to keep it ordered, seems like I was
just lucky to implement the components in the right order :-)

Anyway, yes, please keep it ordered. When you fix that, you may add

Acked-by: Karel Balej <balejk@matfyz.cz> # for the PMIC

Thanks,
K. B.