arm64: dts: xilinx: Drop undocumented "always-on" properties

[PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

Posted by Rob Herring (Arm) 1 month ago

The "always-on" properties are not documented for "silabs,si5341"
binding nor used by the Linux driver, so drop them.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 8 --------
 arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 6 ------
 arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 6 ------
 3 files changed, 20 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index e172a30e7b21..6bee21d4fa4d 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -552,42 +552,34 @@ si5341: clock-generator@36 { /* SI5341 - u69 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_4: out@4 {
 					/* refclk4 for PS-GT, used for PCIE slot */
 					reg = <4>;
-					always-on;
 				};
 				si5341_5: out@5 {
 					/* refclk5 for PS-GT, used for PCIE */
 					reg = <5>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_7: out@7 {
 					/* refclk7 PL CLK74 */
 					reg = <7>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 		};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index cd132abf6e00..f450fad0edf8 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -551,32 +551,26 @@ si5341: clock-generator@36 { /* SI5341 - u69 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_7: out@7 {
 					/* refclk7 PL CLK74 */
 					reg = <7>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
index 428b5558fbba..b4768f615182 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
@@ -439,32 +439,26 @@ si5341: clock-generator@36 { /* SI5341 - u46 */
 				si5341_0: out@0 {
 					/* refclk0 for PS-GT, used for DP */
 					reg = <0>;
-					always-on;
 				};
 				si5341_2: out@2 {
 					/* refclk2 for PS-GT, used for USB3 */
 					reg = <2>;
-					always-on;
 				};
 				si5341_3: out@3 {
 					/* refclk3 for PS-GT, used for SATA */
 					reg = <3>;
-					always-on;
 				};
 				si5341_5: out@5 {
 					/* refclk5 PL CLK100 */
 					reg = <5>;
-					always-on;
 				};
 				si5341_6: out@6 {
 					/* refclk6 PL CLK125 */
 					reg = <6>;
-					always-on;
 				};
 				si5341_9: out@9 {
 					/* refclk9 used for PS_REF_CLK 33.3 MHz */
 					reg = <9>;
-					always-on;
 				};
 			};
 		};
-- 
2.50.1

Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

Posted by Michal Simek 1 month ago

Hi,

On 8/28/25 23:30, Rob Herring (Arm) wrote:
> The "always-on" properties are not documented for "silabs,si5341"
> binding nor used by the Linux driver, so drop them.

Binding
Documentation/devicetree/bindings/clock/silabs,si5341.txt
doesn't contain it
but driver drivers/clk/clk-si5341.c is reading it.

1345                 config[num].always_on =
1346                         of_property_read_bool(child, "always-on");

It is there from 2019 when driver has been added.

If it is not standard clock property it should be moved to standard one.
And DT binding should be converted to yaml with all properties used today.

Thanks,
Michal

Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

Posted by Rob Herring 4 weeks, 1 day ago

On Fri, Aug 29, 2025 at 12:46 AM Michal Simek <michal.simek@amd.com> wrote:
>
> Hi,
>
> On 8/28/25 23:30, Rob Herring (Arm) wrote:
> > The "always-on" properties are not documented for "silabs,si5341"
> > binding nor used by the Linux driver, so drop them.
>
> Binding
> Documentation/devicetree/bindings/clock/silabs,si5341.txt
> doesn't contain it
> but driver drivers/clk/clk-si5341.c is reading it.
>
> 1345                 config[num].always_on =
> 1346                         of_property_read_bool(child, "always-on");
>
> It is there from 2019 when driver has been added.

Sigh. I checked and missed that. We should just add it to the binding.

Rob

Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

Posted by Mike Looijmans 1 month ago

On 29-08-2025 07:46, Michal Simek wrote:
> Hi,
>
> On 8/28/25 23:30, Rob Herring (Arm) wrote:
>> The "always-on" properties are not documented for "silabs,si5341"
>> binding nor used by the Linux driver, so drop them.
>
> Binding
> Documentation/devicetree/bindings/clock/silabs,si5341.txt
> doesn't contain it
> but driver drivers/clk/clk-si5341.c is reading it.
>
> 1345                 config[num].always_on =
> 1346                         of_property_read_bool(child, "always-on");
>
> It is there from 2019 when driver has been added.
>
> If it is not standard clock property it should be moved to standard one.

Agree - either "always-on" should become a standard property, or it should be 
removed from the driver.

As a standard property, akin to "regulator-always-on", maybe it should 
probably be renamed to "clock-always-on"?

I'd be happy to provide a patch either way.


> And DT binding should be converted to yaml with all properties used today.
>
> Thanks,
> Michal
>
>
Mike.

Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

Posted by Krzysztof Kozlowski 1 month ago

On 29/08/2025 08:25, Mike Looijmans wrote:
> On 29-08-2025 07:46, Michal Simek wrote:
>> Hi,
>>
>> On 8/28/25 23:30, Rob Herring (Arm) wrote:
>>> The "always-on" properties are not documented for "silabs,si5341"
>>> binding nor used by the Linux driver, so drop them.
>>
>> Binding
>> Documentation/devicetree/bindings/clock/silabs,si5341.txt
>> doesn't contain it
>> but driver drivers/clk/clk-si5341.c is reading it.
>>
>> 1345                 config[num].always_on =
>> 1346                         of_property_read_bool(child, "always-on");
>>
>> It is there from 2019 when driver has been added.
>>
>> If it is not standard clock property it should be moved to standard one.
> 
> Agree - either "always-on" should become a standard property, or it should be 
> removed from the driver.
> 
> As a standard property, akin to "regulator-always-on", maybe it should 
> probably be renamed to "clock-always-on"?
> 
> I'd be happy to provide a patch either way.

That's an implied ABI now, so you cannot remove it, but about
"clock-always-on" - it does not look like a property we want in DT. If
on one board this is always connected (but on other not), you should
take the proper clock reference.

> 


Best regards,
Krzysztof