[v2] selftests/thermel/intel/workload_hint: Mask unsupported types

[PATCH v2] selftests/thermel/intel/workload_hint: Mask unsupported types

Posted by Srinivas Pandruvada 1 month ago

The workload hint may contain some other hints which are not defined.
So mask out unsupported types. Currently only lower 4 bits of workload
type hints are defined.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
v2:
- Removed extra line

 .../selftests/thermal/intel/workload_hint/workload_hint_test.c  | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
index ba58589a1145..ca2bd03154e4 100644
--- a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
+++ b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
@@ -144,6 +144,8 @@ int main(int argc, char **argv)
 			ret = sscanf(index_str, "%d", &index);
 			if (ret < 0)
 				break;
+
+			index &= 0x0f;
 			if (index > WORKLOAD_TYPE_MAX_INDEX)
 				printf("Invalid workload type index\n");
 			else
-- 
2.43.0

Re: [PATCH v2] selftests/thermel/intel/workload_hint: Mask unsupported types

Posted by Rafael J. Wysocki 4 weeks ago

On Thu, Aug 28, 2025 at 10:15 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> The workload hint may contain some other hints which are not defined.
> So mask out unsupported types. Currently only lower 4 bits of workload
> type hints are defined.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> v2:
> - Removed extra line
>
>  .../selftests/thermal/intel/workload_hint/workload_hint_test.c  | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
> index ba58589a1145..ca2bd03154e4 100644
> --- a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
> +++ b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
> @@ -144,6 +144,8 @@ int main(int argc, char **argv)
>                         ret = sscanf(index_str, "%d", &index);
>                         if (ret < 0)
>                                 break;
> +
> +                       index &= 0x0f;
>                         if (index > WORKLOAD_TYPE_MAX_INDEX)
>                                 printf("Invalid workload type index\n");
>                         else
> --

Applied, thanks!