1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1

Christian Hewitt posted 1 patch 5 months, 1 week ago 
arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
[PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Christian Hewitt 5 months, 1 week ago 
From: Alex Bee <knaerzche@gmail.com>

Add the required nodes to enable SPDIF audio output on
the Beelink A1 set-top-box.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
index f7c4578865c5..b276a29bdd85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
@@ -58,6 +58,24 @@ ir-receiver {
 		gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
 		linux,rc-map-name = "rc-beelink-gs1";
 	};
+
+	spdif_sound: spdif-sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "SPDIF";
+
+		simple-audio-card,cpu {
+			sound-dai = <&spdif>;
+		};
+
+		simple-audio-card,codec {
+			sound-dai = <&spdif_dit>;
+		};
+	};
+
+	spdif_dit: spdif-dit {
+		compatible = "linux,spdif-dit";
+		#sound-dai-cells = <0>;
+	};
 };
 
 &analog_sound {
@@ -325,6 +343,11 @@ &sdmmc {
 	status = "okay";
 };
 
+&spdif {
+	pinctrl-0 = <&spdifm0_tx>;
+	status = "okay";
+};
+
 &tsadc {
 	rockchip,hw-tshut-mode = <0>;
 	rockchip,hw-tshut-polarity = <0>;
-- 
2.34.1
Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Robin Murphy 2 months ago 
[ Just noticed this... ]

On 2025-08-28 5:43 pm, Christian Hewitt wrote:
> From: Alex Bee <knaerzche@gmail.com>
> 
> Add the required nodes to enable SPDIF audio output on
> the Beelink A1 set-top-box.

But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to 
the analog audio codec (and possibly the composite TV out) :/

Thanks,
Robin.

> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> index f7c4578865c5..b276a29bdd85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> @@ -58,6 +58,24 @@ ir-receiver {
>   		gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>   		linux,rc-map-name = "rc-beelink-gs1";
>   	};
> +
> +	spdif_sound: spdif-sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "SPDIF";
> +
> +		simple-audio-card,cpu {
> +			sound-dai = <&spdif>;
> +		};
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&spdif_dit>;
> +		};
> +	};
> +
> +	spdif_dit: spdif-dit {
> +		compatible = "linux,spdif-dit";
> +		#sound-dai-cells = <0>;
> +	};
>   };
>   
>   &analog_sound {
> @@ -325,6 +343,11 @@ &sdmmc {
>   	status = "okay";
>   };
>   
> +&spdif {
> +	pinctrl-0 = <&spdifm0_tx>;
> +	status = "okay";
> +};
> +
>   &tsadc {
>   	rockchip,hw-tshut-mode = <0>;
>   	rockchip,hw-tshut-polarity = <0>;
Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Alex Bee 2 months ago 
Hi Robin,

Am 03.12.25 um 17:21 schrieb Robin Murphy:
> [ Just noticed this... ]
>
> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>> From: Alex Bee <knaerzche@gmail.com>
>>
>> Add the required nodes to enable SPDIF audio output on
>> the Beelink A1 set-top-box.
>
> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected 
> to the analog audio codec (and possibly the composite TV out) :/
>
Yeah, sorry - this patch wasn't supposed to be submitted upstream.

Regards,

Alex

> Thanks,
> Robin.
>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts 
>> b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> index f7c4578865c5..b276a29bdd85 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> @@ -58,6 +58,24 @@ ir-receiver {
>>           gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>           linux,rc-map-name = "rc-beelink-gs1";
>>       };
>> +
>> +    spdif_sound: spdif-sound {
>> +        compatible = "simple-audio-card";
>> +        simple-audio-card,name = "SPDIF";
>> +
>> +        simple-audio-card,cpu {
>> +            sound-dai = <&spdif>;
>> +        };
>> +
>> +        simple-audio-card,codec {
>> +            sound-dai = <&spdif_dit>;
>> +        };
>> +    };
>> +
>> +    spdif_dit: spdif-dit {
>> +        compatible = "linux,spdif-dit";
>> +        #sound-dai-cells = <0>;
>> +    };
>>   };
>>     &analog_sound {
>> @@ -325,6 +343,11 @@ &sdmmc {
>>       status = "okay";
>>   };
>>   +&spdif {
>> +    pinctrl-0 = <&spdifm0_tx>;
>> +    status = "okay";
>> +};
>> +
>>   &tsadc {
>>       rockchip,hw-tshut-mode = <0>;
>>       rockchip,hw-tshut-polarity = <0>;
Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Christian Hewitt 2 months ago 
> On 4 Dec 2025, at 12:23 am, Alex Bee <knaerzche@gmail.com> wrote:
> 
> Hi Robin,
> 
> Am 03.12.25 um 17:21 schrieb Robin Murphy:
>> [ Just noticed this... ]
>> 
>> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>>> From: Alex Bee <knaerzche@gmail.com>
>>> 
>>> Add the required nodes to enable SPDIF audio output on
>>> the Beelink A1 set-top-box.
>> 
>> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to the analog audio codec (and possibly the composite TV out) :/
>> 
> Yeah, sorry - this patch wasn't supposed to be submitted upstream.

Apologies, this is my enthusiasm for trying to clear out the patch
collection LibreELEC has been hoarding by sending things upstream
on behalf of the original authors (and hoarders).

Would you like me to send a revert patch?

Christian

> Regards,
> 
> Alex
> 
>> Thanks,
>> Robin.
>> 
>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>> ---
>>>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>>   1 file changed, 23 insertions(+)
>>> 
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> index f7c4578865c5..b276a29bdd85 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> @@ -58,6 +58,24 @@ ir-receiver {
>>>           gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>>           linux,rc-map-name = "rc-beelink-gs1";
>>>       };
>>> +
>>> +    spdif_sound: spdif-sound {
>>> +        compatible = "simple-audio-card";
>>> +        simple-audio-card,name = "SPDIF";
>>> +
>>> +        simple-audio-card,cpu {
>>> +            sound-dai = <&spdif>;
>>> +        };
>>> +
>>> +        simple-audio-card,codec {
>>> +            sound-dai = <&spdif_dit>;
>>> +        };
>>> +    };
>>> +
>>> +    spdif_dit: spdif-dit {
>>> +        compatible = "linux,spdif-dit";
>>> +        #sound-dai-cells = <0>;
>>> +    };
>>>   };
>>>     &analog_sound {
>>> @@ -325,6 +343,11 @@ &sdmmc {
>>>       status = "okay";
>>>   };
>>>   +&spdif {
>>> +    pinctrl-0 = <&spdifm0_tx>;
>>> +    status = "okay";
>>> +};
>>> +
>>>   &tsadc {
>>>       rockchip,hw-tshut-mode = <0>;
>>>       rockchip,hw-tshut-polarity = <0>;
Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Robin Murphy 2 months ago 
On 2025-12-04 2:13 pm, Christian Hewitt wrote:
>> On 4 Dec 2025, at 12:23 am, Alex Bee <knaerzche@gmail.com> wrote:
>>
>> Hi Robin,
>>
>> Am 03.12.25 um 17:21 schrieb Robin Murphy:
>>> [ Just noticed this... ]
>>>
>>> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>>>> From: Alex Bee <knaerzche@gmail.com>
>>>>
>>>> Add the required nodes to enable SPDIF audio output on
>>>> the Beelink A1 set-top-box.
>>>
>>> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to the analog audio codec (and possibly the composite TV out) :/
>>>
>> Yeah, sorry - this patch wasn't supposed to be submitted upstream.
> 
> Apologies, this is my enthusiasm for trying to clear out the patch
> collection LibreELEC has been hoarding by sending things upstream
> on behalf of the original authors (and hoarders).

No worries :)

> Would you like me to send a revert patch?

Since I'm the only one complaining, and I'm liable to have a couple more 
Rockchip DT patches to send soon anyway, feel free to leave it with me 
unless you're particularly keen.

Cheers,
Robin.

> 
> Christian
> 
>> Regards,
>>
>> Alex
>>
>>> Thanks,
>>> Robin.
>>>
>>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>> ---
>>>>    arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>>>    1 file changed, 23 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> index f7c4578865c5..b276a29bdd85 100644
>>>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> @@ -58,6 +58,24 @@ ir-receiver {
>>>>            gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>>>            linux,rc-map-name = "rc-beelink-gs1";
>>>>        };
>>>> +
>>>> +    spdif_sound: spdif-sound {
>>>> +        compatible = "simple-audio-card";
>>>> +        simple-audio-card,name = "SPDIF";
>>>> +
>>>> +        simple-audio-card,cpu {
>>>> +            sound-dai = <&spdif>;
>>>> +        };
>>>> +
>>>> +        simple-audio-card,codec {
>>>> +            sound-dai = <&spdif_dit>;
>>>> +        };
>>>> +    };
>>>> +
>>>> +    spdif_dit: spdif-dit {
>>>> +        compatible = "linux,spdif-dit";
>>>> +        #sound-dai-cells = <0>;
>>>> +    };
>>>>    };
>>>>      &analog_sound {
>>>> @@ -325,6 +343,11 @@ &sdmmc {
>>>>        status = "okay";
>>>>    };
>>>>    +&spdif {
>>>> +    pinctrl-0 = <&spdifm0_tx>;
>>>> +    status = "okay";
>>>> +};
>>>> +
>>>>    &tsadc {
>>>>        rockchip,hw-tshut-mode = <0>;
>>>>        rockchip,hw-tshut-polarity = <0>;
>
Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Posted by Heiko Stuebner 5 months, 1 week ago 
On Thu, 28 Aug 2025 16:43:00 +0000, Christian Hewitt wrote:
> Add the required nodes to enable SPDIF audio output on
> the Beelink A1 set-top-box.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: add SPDIF audio to Beelink A1
      commit: 8a449a728cce86183f93a3d1812c94509359719c

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.