[PATCH v3 3/3] ARM: dts: aspeed: harma: add mp5990

Peter Yin posted 3 patches 1 month ago
There is a newer version of this series
[PATCH v3 3/3] ARM: dts: aspeed: harma: add mp5990
Posted by Peter Yin 1 month ago
Add support for the HSC MP5990 device on the Harma platform.

This change updates the device tree to include the MP5990 HSC
(Hot Swap Controller), allowing proper configuration and integration
with the platform.

Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
index 81278a7702de..23eaf47a38e8 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
@@ -520,6 +520,10 @@ imux28: i2c@0 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <0>;
+			power-sensor@20 {
+				compatible = "mps,mp5990";
+				reg = <0x20>;
+			};
 			power-monitor@61 {
 				compatible = "isil,isl69260";
 				reg = <0x61>;
-- 
2.43.0
Re: [PATCH v3 3/3] ARM: dts: aspeed: harma: add mp5990
Posted by Andrew Jeffery 1 month ago
Hi Peter,

On Thu, 2025-08-28 at 15:49 +0800, Peter Yin wrote:
> Add support for the HSC MP5990 device on the Harma platform.
> 
> This change updates the device tree to include the MP5990 HSC
> (Hot Swap Controller), allowing proper configuration and integration
> with the platform.
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index 81278a7702de..23eaf47a38e8 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -520,6 +520,10 @@ imux28: i2c@0 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         reg = <0>;
> +                       power-sensor@20 {
> +                               compatible = "mps,mp5990";
> +                               reg = <0x20>;
> +                       };
>                         power-monitor@61 {
>                                 compatible = "isil,isl69260";
>                                 reg = <0x61>;

I've applied the series, however, can you please send a follow-up patch
adding new-lines between the child nodes of imux28? It's not consistent
with the rest of the devicetree and is a bit dense.

Thanks,

Andrew