[v2] accel/amdxdna: Use int instead of u32 to store error codes

[PATCH v2] accel/amdxdna: Use int instead of u32 to store error codes

Posted by Qianfeng Rong 5 months, 2 weeks ago

Change the 'ret' variable from u32 to int to store -EINVAL.  Storing the
negative error codes in unsigned type, doesn't cause an issue at runtime
but it's ugly as pants.

Additionally, assigning -EINVAL to u32 ret (i.e., u32 ret = -EINVAL) may
trigger a GCC warning when the -Wsign-conversion flag is enabled.

Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
v2: Modified commit message and add a fixes tag as suggested by Lizhi.
---
 drivers/accel/amdxdna/aie2_ctx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index 420467a5325c..e9f9b1fa5dc1 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -199,7 +199,7 @@ aie2_sched_resp_handler(void *handle, void __iomem *data, size_t size)
 {
 	struct amdxdna_sched_job *job = handle;
 	struct amdxdna_gem_obj *cmd_abo;
-	u32 ret = 0;
+	int ret = 0;
 	u32 status;
 
 	cmd_abo = job->cmd_bo;
@@ -229,7 +229,7 @@ static int
 aie2_sched_nocmd_resp_handler(void *handle, void __iomem *data, size_t size)
 {
 	struct amdxdna_sched_job *job = handle;
-	u32 ret = 0;
+	int ret = 0;
 	u32 status;
 
 	if (unlikely(!data))
@@ -257,7 +257,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
 	u32 fail_cmd_status;
 	u32 fail_cmd_idx;
 	u32 cmd_status;
-	u32 ret = 0;
+	int ret = 0;
 
 	cmd_abo = job->cmd_bo;
 	if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) {
-- 
2.34.1

Re: [PATCH v2] accel/amdxdna: Use int instead of u32 to store error codes

Posted by Lizhi Hou 5 months, 2 weeks ago

Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>

On 8/27/25 20:39, Qianfeng Rong wrote:
> Change the 'ret' variable from u32 to int to store -EINVAL.  Storing the
> negative error codes in unsigned type, doesn't cause an issue at runtime
> but it's ugly as pants.
>
> Additionally, assigning -EINVAL to u32 ret (i.e., u32 ret = -EINVAL) may
> trigger a GCC warning when the -Wsign-conversion flag is enabled.
>
> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> v2: Modified commit message and add a fixes tag as suggested by Lizhi.
> ---
>   drivers/accel/amdxdna/aie2_ctx.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 420467a5325c..e9f9b1fa5dc1 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -199,7 +199,7 @@ aie2_sched_resp_handler(void *handle, void __iomem *data, size_t size)
>   {
>   	struct amdxdna_sched_job *job = handle;
>   	struct amdxdna_gem_obj *cmd_abo;
> -	u32 ret = 0;
> +	int ret = 0;
>   	u32 status;
>   
>   	cmd_abo = job->cmd_bo;
> @@ -229,7 +229,7 @@ static int
>   aie2_sched_nocmd_resp_handler(void *handle, void __iomem *data, size_t size)
>   {
>   	struct amdxdna_sched_job *job = handle;
> -	u32 ret = 0;
> +	int ret = 0;
>   	u32 status;
>   
>   	if (unlikely(!data))
> @@ -257,7 +257,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
>   	u32 fail_cmd_status;
>   	u32 fail_cmd_idx;
>   	u32 cmd_status;
> -	u32 ret = 0;
> +	int ret = 0;
>   
>   	cmd_abo = job->cmd_bo;
>   	if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) {

Re: [PATCH v2] accel/amdxdna: Use int instead of u32 to store error codes

Posted by Lizhi Hou 5 months, 1 week ago

Applied to drm-misc-next.

On 8/28/25 13:23, Lizhi Hou wrote:
> Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
>
> On 8/27/25 20:39, Qianfeng Rong wrote:
>> Change the 'ret' variable from u32 to int to store -EINVAL.  Storing the
>> negative error codes in unsigned type, doesn't cause an issue at runtime
>> but it's ugly as pants.
>>
>> Additionally, assigning -EINVAL to u32 ret (i.e., u32 ret = -EINVAL) may
>> trigger a GCC warning when the -Wsign-conversion flag is enabled.
>>
>> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
>> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
>> ---
>> v2: Modified commit message and add a fixes tag as suggested by Lizhi.
>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index 420467a5325c..e9f9b1fa5dc1 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -199,7 +199,7 @@ aie2_sched_resp_handler(void *handle, void 
>> __iomem *data, size_t size)
>>   {
>>       struct amdxdna_sched_job *job = handle;
>>       struct amdxdna_gem_obj *cmd_abo;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>       u32 status;
>>         cmd_abo = job->cmd_bo;
>> @@ -229,7 +229,7 @@ static int
>>   aie2_sched_nocmd_resp_handler(void *handle, void __iomem *data, 
>> size_t size)
>>   {
>>       struct amdxdna_sched_job *job = handle;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>       u32 status;
>>         if (unlikely(!data))
>> @@ -257,7 +257,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, 
>> void __iomem *data, size_t size)
>>       u32 fail_cmd_status;
>>       u32 fail_cmd_idx;
>>       u32 cmd_status;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>         cmd_abo = job->cmd_bo;
>>       if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) {