[v9] Add driver for 1Gbe network chips from MUCSE

[PATCH net-next v9 0/5] Add driver for 1Gbe network chips from MUCSE

Posted by Dong Yibo 1 month ago

Hi maintainers,

This patch series is v9 to introduce support for MUCSE N500/N210 1Gbps
Ethernet controllers. I divide codes into multiple series, this is the
first one which only register netdev without true tx/rx functions.

Changelog:
v8 -> v9:
1. update function description format '@return' to 'Return' 
2. update 'negative on failure' to 'negative errno on failure'

links:
v8: https://lore.kernel.org/netdev/20250827034509.501980-1-dong100@mucse.com/
v7: https://lore.kernel.org/netdev/20250822023453.1910972-1-dong100@mucse.com
v6: https://lore.kernel.org/netdev/20250820092154.1643120-1-dong100@mucse.com/
v5: https://lore.kernel.org/netdev/20250818112856.1446278-1-dong100@mucse.com/
v4: https://lore.kernel.org/netdev/20250814073855.1060601-1-dong100@mucse.com/
v3: https://lore.kernel.org/netdev/20250812093937.882045-1-dong100@mucse.com/
v2: https://lore.kernel.org/netdev/20250721113238.18615-1-dong100@mucse.com/
v1: https://lore.kernel.org/netdev/20250703014859.210110-1-dong100@mucse.com/

Dong Yibo (5):
  net: rnpgbe: Add build support for rnpgbe
  net: rnpgbe: Add n500/n210 chip support
  net: rnpgbe: Add basic mbx ops support
  net: rnpgbe: Add basic mbx_fw support
  net: rnpgbe: Add register_netdev

 .../device_drivers/ethernet/index.rst         |   1 +
 .../device_drivers/ethernet/mucse/rnpgbe.rst  |  21 +
 MAINTAINERS                                   |   8 +
 drivers/net/ethernet/Kconfig                  |   1 +
 drivers/net/ethernet/Makefile                 |   1 +
 drivers/net/ethernet/mucse/Kconfig            |  34 ++
 drivers/net/ethernet/mucse/Makefile           |   7 +
 drivers/net/ethernet/mucse/rnpgbe/Makefile    |  11 +
 drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h    |  98 +++++
 .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c   | 153 +++++++
 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h |  18 +
 .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c   | 286 +++++++++++++
 .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c    | 393 ++++++++++++++++++
 .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h    |  25 ++
 .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 253 +++++++++++
 .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h | 126 ++++++
 16 files changed, 1436 insertions(+)
 create mode 100644 Documentation/networking/device_drivers/ethernet/mucse/rnpgbe.rst
 create mode 100644 drivers/net/ethernet/mucse/Kconfig
 create mode 100644 drivers/net/ethernet/mucse/Makefile
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/Makefile
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c
 create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h

-- 
2.25.1

Re: [PATCH net-next v9 0/5] Add driver for 1Gbe network chips from MUCSE

Posted by MD Danish Anwar 1 month ago

Hi Dong Yibo,

On 28/08/25 8:25 am, Dong Yibo wrote:
> Hi maintainers,
> 
> This patch series is v9 to introduce support for MUCSE N500/N210 1Gbps
> Ethernet controllers. I divide codes into multiple series, this is the
> first one which only register netdev without true tx/rx functions.
> 
> Changelog:
> v8 -> v9:
> 1. update function description format '@return' to 'Return' 
> 2. update 'negative on failure' to 'negative errno on failure'
> 
> links:
> v8: https://lore.kernel.org/netdev/20250827034509.501980-1-dong100@mucse.com/
> v7: https://lore.kernel.org/netdev/20250822023453.1910972-1-dong100@mucse.com
> v6: https://lore.kernel.org/netdev/20250820092154.1643120-1-dong100@mucse.com/
> v5: https://lore.kernel.org/netdev/20250818112856.1446278-1-dong100@mucse.com/
> v4: https://lore.kernel.org/netdev/20250814073855.1060601-1-dong100@mucse.com/
> v3: https://lore.kernel.org/netdev/20250812093937.882045-1-dong100@mucse.com/
> v2: https://lore.kernel.org/netdev/20250721113238.18615-1-dong100@mucse.com/
> v1: https://lore.kernel.org/netdev/20250703014859.210110-1-dong100@mucse.com/

Please wait for at least 24 hours before posting a new version. You
posted v8 yesterday and most folks won't have noticed v8 by now or they
maybe looking to give comments on v8. But before they could do that you
posted v9.

Keep good amount of gaps between the series so that more folks can look
at it. 24 hours is the minimum.

-- 
Thanks and Regards,
Danish

Re: [PATCH net-next v9 0/5] Add driver for 1Gbe network chips from MUCSE

Posted by Yibo Dong 1 month ago

On Thu, Aug 28, 2025 at 10:52:21AM +0530, MD Danish Anwar wrote:
> Hi Dong Yibo,
> 
> On 28/08/25 8:25 am, Dong Yibo wrote:
> > Hi maintainers,
> > 
> > This patch series is v9 to introduce support for MUCSE N500/N210 1Gbps
> > Ethernet controllers. I divide codes into multiple series, this is the
> > first one which only register netdev without true tx/rx functions.
> > 
> > Changelog:
> > v8 -> v9:
> > 1. update function description format '@return' to 'Return' 
> > 2. update 'negative on failure' to 'negative errno on failure'
> > 
> > links:
> > v8: https://lore.kernel.org/netdev/20250827034509.501980-1-dong100@mucse.com/
> > v7: https://lore.kernel.org/netdev/20250822023453.1910972-1-dong100@mucse.com
> > v6: https://lore.kernel.org/netdev/20250820092154.1643120-1-dong100@mucse.com/
> > v5: https://lore.kernel.org/netdev/20250818112856.1446278-1-dong100@mucse.com/
> > v4: https://lore.kernel.org/netdev/20250814073855.1060601-1-dong100@mucse.com/
> > v3: https://lore.kernel.org/netdev/20250812093937.882045-1-dong100@mucse.com/
> > v2: https://lore.kernel.org/netdev/20250721113238.18615-1-dong100@mucse.com/
> > v1: https://lore.kernel.org/netdev/20250703014859.210110-1-dong100@mucse.com/
> 
> Please wait for at least 24 hours before posting a new version. You
> posted v8 yesterday and most folks won't have noticed v8 by now or they
> maybe looking to give comments on v8. But before they could do that you
> posted v9.
> 
> Keep good amount of gaps between the series so that more folks can look
> at it. 24 hours is the minimum.
> 
> -- 
> Thanks and Regards,
> Danish
> 
> 

Got it, I found the v8 pathes state in websit:
https://patchwork.kernel.org/project/netdevbpf/list/
It is 'Changes Requested'. 
I mistakenly thought that a new version needed to be sent. I will wait
more time in the next time.

Thanks for you feedback.

Re: [PATCH net-next v9 0/5] Add driver for 1Gbe network chips from MUCSE

Posted by Andrew Lunn 1 month ago

> Got it, I found the v8 pathes state in websit:
> https://patchwork.kernel.org/project/netdevbpf/list/
> It is 'Changes Requested'. 
> I mistakenly thought that a new version needed to be sent. I will wait
> more time in the next time.

We try to review patches within 3 working days. Depending on reviewer
work load, you might get comments really fast, or it might take 3
days. The 24 hour requirement between new spins is a compromise.  But
you should also listen to your audience. If there have been active
reviews and they have not commented yet, maybe wait the full three
days.

	Andrew

Re: [PATCH net-next v9 0/5] Add driver for 1Gbe network chips from MUCSE

Posted by MD Danish Anwar 1 month ago


On 28/08/25 11:06 am, Yibo Dong wrote:
> On Thu, Aug 28, 2025 at 10:52:21AM +0530, MD Danish Anwar wrote:
>> Hi Dong Yibo,
>>
>> On 28/08/25 8:25 am, Dong Yibo wrote:
>>> Hi maintainers,
>>>
>>> This patch series is v9 to introduce support for MUCSE N500/N210 1Gbps
>>> Ethernet controllers. I divide codes into multiple series, this is the
>>> first one which only register netdev without true tx/rx functions.
>>>
>>> Changelog:
>>> v8 -> v9:
>>> 1. update function description format '@return' to 'Return' 
>>> 2. update 'negative on failure' to 'negative errno on failure'
>>>
>>> links:
>>> v8: https://lore.kernel.org/netdev/20250827034509.501980-1-dong100@mucse.com/
>>> v7: https://lore.kernel.org/netdev/20250822023453.1910972-1-dong100@mucse.com
>>> v6: https://lore.kernel.org/netdev/20250820092154.1643120-1-dong100@mucse.com/
>>> v5: https://lore.kernel.org/netdev/20250818112856.1446278-1-dong100@mucse.com/
>>> v4: https://lore.kernel.org/netdev/20250814073855.1060601-1-dong100@mucse.com/
>>> v3: https://lore.kernel.org/netdev/20250812093937.882045-1-dong100@mucse.com/
>>> v2: https://lore.kernel.org/netdev/20250721113238.18615-1-dong100@mucse.com/
>>> v1: https://lore.kernel.org/netdev/20250703014859.210110-1-dong100@mucse.com/
>>
>> Please wait for at least 24 hours before posting a new version. You
>> posted v8 yesterday and most folks won't have noticed v8 by now or they
>> maybe looking to give comments on v8. But before they could do that you
>> posted v9.
>>
>> Keep good amount of gaps between the series so that more folks can look
>> at it. 24 hours is the minimum.
>>
>> -- 
>> Thanks and Regards,
>> Danish
>>
>>
> 
> Got it, I found the v8 pathes state in websit:
> https://patchwork.kernel.org/project/netdevbpf/list/
> It is 'Changes Requested'. 
> I mistakenly thought that a new version needed to be sent. I will wait

That's correct. 'Changes Requested' means that version will no longer be
accepted and you have to send a newer one. But that doesn't mean you
have to send it immediately.

https://www.kernel.org/doc/html/v6.1/process/maintainer-netdev.html#i-have-received-review-feedback-when-should-i-post-a-revised-version-of-the-patches


> more time in the next time.
> 
> Thanks for you feedback.

-- 
Thanks and Regards,
Danish