From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Some tests are invalid on 32bit due to the size of the index and last.
Making those tests depend on the correct build flags stops compile
complaints.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 tools/testing/radix-tree/maple.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
index 172700fb7784d..90a0db45a33c3 100644
--- a/tools/testing/radix-tree/maple.c
+++ b/tools/testing/radix-tree/maple.c
@@ -36428,6 +36428,7 @@ static void check_nomem_writer_race(struct maple_tree *mt)
   */
 static inline int check_vma_modification(struct maple_tree *mt)
 {
+#if defined(CONFIG_64BIT)
 	MA_STATE(mas, mt, 0, 0);
 
 	mtree_lock(mt);
@@ -36451,6 +36452,8 @@ static inline int check_vma_modification(struct maple_tree *mt)
 
 	mas_destroy(&mas);
 	mtree_unlock(mt);
+#endif
+
 	return 0;
 }
 
-- 
2.47.2

On 8/27/25 8:30 PM, Liam R. Howlett wrote:
> From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> 
> Some tests are invalid on 32bit due to the size of the index and last.
> Making those tests depend on the correct build flags stops compile
> complaints.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

Should a fixes tag also be added?

Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()")

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>

> ---
>   tools/testing/radix-tree/maple.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 172700fb7784d..90a0db45a33c3 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -36428,6 +36428,7 @@ static void check_nomem_writer_race(struct maple_tree *mt)
>     */
>   static inline int check_vma_modification(struct maple_tree *mt)
>   {
> +#if defined(CONFIG_64BIT)
>   	MA_STATE(mas, mt, 0, 0);
>   
>   	mtree_lock(mt);
> @@ -36451,6 +36452,8 @@ static inline int check_vma_modification(struct maple_tree *mt)
>   
>   	mas_destroy(&mas);
>   	mtree_unlock(mt);
> +#endif
> +
>   	return 0;
>   }
>

* Sidhartha Kumar <sidhartha.kumar@oracle.com> [250828 11:12]:
> On 8/27/25 8:30 PM, Liam R. Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> > 
> > Some tests are invalid on 32bit due to the size of the index and last.
> > Making those tests depend on the correct build flags stops compile
> > complaints.
> > 
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> 
> Should a fixes tag also be added?

Well, it's a test fix, so there really isn't an issue with the actual
code.. and it's for 32bit.

I don't think we need it backported, but I guess the tag doesn't hurt.

Thanks!

> 
> Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()")
> 
> Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> 
> > ---
> >   tools/testing/radix-tree/maple.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> > index 172700fb7784d..90a0db45a33c3 100644
> > --- a/tools/testing/radix-tree/maple.c
> > +++ b/tools/testing/radix-tree/maple.c
> > @@ -36428,6 +36428,7 @@ static void check_nomem_writer_race(struct maple_tree *mt)
> >     */
> >   static inline int check_vma_modification(struct maple_tree *mt)
> >   {
> > +#if defined(CONFIG_64BIT)
> >   	MA_STATE(mas, mt, 0, 0);
> >   	mtree_lock(mt);
> > @@ -36451,6 +36452,8 @@ static inline int check_vma_modification(struct maple_tree *mt)
> >   	mas_destroy(&mas);
> >   	mtree_unlock(mt);
> > +#endif
> > +
> >   	return 0;
> >   }
>