gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

[PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Antheas Kapenekakis 5 months, 1 week ago

Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.

Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/gpio/gpiolib-acpi-quirks.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index c13545dce349..bb63138c4b5b 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -317,6 +317,18 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "PNP0C50:00@8",
 		},
 	},
+	{
+		/*
+		 * Same as G1619-04. New model.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "G1619-05"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "PNP0C50:00@8",
+		},
+	},
 	{
 		/*
 		 * Spurious wakeups from GPIO 11

base-commit: 1b237f190eb3d36f52dffe07a40b5eb210280e00
-- 
2.51.0

Re: [PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Andy Shevchenko 5 months, 1 week ago

On Wed, Aug 27, 2025 at 07:58:42PM +0200, Antheas Kapenekakis wrote:
> Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
> touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Bartosz Golaszewski 5 months, 1 week ago

On Wed, Aug 27, 2025 at 8:00 PM Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
> touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.
>
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---

Andy, should I take it directly through the GPIO tree?

Bart

Re: [PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Andy Shevchenko 5 months, 1 week ago

On Sat, Aug 30, 2025 at 09:51:19PM +0200, Bartosz Golaszewski wrote:
> On Wed, Aug 27, 2025 at 8:00 PM Antheas Kapenekakis <lkml@antheas.dev> wrote:
> >
> > Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
> > touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> > ---
> 
> Andy, should I take it directly through the GPIO tree?

Nope, I have already something, I will take it, thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Mika Westerberg 5 months, 1 week ago

On Wed, Aug 27, 2025 at 07:58:42PM +0200, Antheas Kapenekakis wrote:
> Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
> touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.
> 
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>

Reviewed-by: Mika Westerberg <westeri@kernel.org>

Re: [PATCH v1] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-05

Posted by Limonciello, Mario 5 months, 1 week ago

On 8/28/25 12:10 AM, Mika Westerberg wrote:
> On Wed, Aug 27, 2025 at 07:58:42PM +0200, Antheas Kapenekakis wrote:
>> Same issue as G1619-04 in commit 805c74eac8cb ("gpiolib: acpi: Ignore
>> touchpad wakeup on GPD G1619-04"), Strix Point lineup uses 05.
>>
>> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> 
> Reviewed-by: Mika Westerberg <westeri@kernel.org>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

However as this is the second year in a row with this exact same issue I 
would also ask if you can please contact the manufacturer to fix it in 
the BIOS for future models so we can hopefully stop accumulating quirks.