[PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1

Gary Yang posted 3 patches 1 month, 1 week ago
[PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1
Posted by Gary Yang 1 month, 1 week ago
Add the pin-controller nodes for Sky1 platform.

Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
 arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 28 +++++++++++++++++++++++
 arch/arm64/boot/dts/cix/sky1.dtsi         | 10 ++++++++
 2 files changed, 38 insertions(+)

diff --git a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
index d74964d53c3b..8fab0c3b36b3 100644
--- a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
+++ b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
@@ -7,6 +7,9 @@
 /dts-v1/;
 
 #include "sky1.dtsi"
+
+#include <dt-bindings/pinctrl/pads-sky1.h>
+
 / {
 	model = "Radxa Orion O6";
 	compatible = "radxa,orion-o6", "cix,sky1";
@@ -34,6 +37,31 @@ linux,cma {
 
 };
 
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hog-pins {
+		cix,pins = <
+			CIX_PAD_GPIO144_OFFSET CIX_PAD_GPIO144_FUNC_GPIO144 (PULL_DOWN|DS_LEVEL4)
+			CIX_PAD_GPIO145_OFFSET CIX_PAD_GPIO145_FUNC_GPIO145 (PULL_DOWN|DS_LEVEL4)
+			CIX_PAD_GPIO146_OFFSET CIX_PAD_GPIO146_FUNC_GPIO146 (PULL_DOWN|DS_LEVEL4)
+			CIX_PAD_GPIO147_OFFSET CIX_PAD_GPIO147_FUNC_GPIO147 (PULL_DOWN|DS_LEVEL4)
+		>;
+	};
+};
+
+&iomuxc_s5 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog_s5>;
+
+	pinctrl_hog_s5: hog-s5-pins {
+		cix,pins = <
+			CIX_PAD_GPIO014_OFFSET CIX_PAD_GPIO014_FUNC_GPIO014  (PULL_UP|DS_LEVEL4)
+		>;
+	};
+};
+
 &uart2 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
index 7dfe7677e649..bfe34e5311e8 100644
--- a/arch/arm64/boot/dts/cix/sky1.dtsi
+++ b/arch/arm64/boot/dts/cix/sky1.dtsi
@@ -316,6 +316,16 @@ ppi_partition1: interrupt-partition-1 {
 				};
 			};
 		};
+
+		iomuxc: pinctrl@4170000 {
+			compatible = "cix,sky1-iomuxc";
+			reg = <0x0 0x04170000 0x0 0x1000>;
+		};
+
+		iomuxc_s5: pinctrl@16007000 {
+			compatible = "cix,sky1-iomuxc-s5";
+			reg = <0x0 0x16007000 0x0 0x1000>;
+		};
 	};
 
 	timer {
-- 
2.49.0
Re: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 27/08/2025 04:42, Gary Yang wrote:
>  			};
>  		};
> +
> +		iomuxc: pinctrl@4170000 {
> +			compatible = "cix,sky1-iomuxc";
> +			reg = <0x0 0x04170000 0x0 0x1000>;
> +		};
> +
> +		iomuxc_s5: pinctrl@16007000 {

Are you sure you follow DTS coding style for ordering of nodes? Looks
like you just keep adding things to the end...

> +			compatible = "cix,sky1-iomuxc-s5";
> +			reg = <0x0 0x16007000 0x0 0x1000>;
> +		};
>  	};
>  
>  	timer {


Best regards,
Krzysztof