Rename kvm_tdp_map_page() to kvm_tdp_prefault_page() now that it's used
only by kvm_arch_vcpu_pre_fault_memory().

No functional change intended.

Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/kvm/mmu/mmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index f532beed9029..cb08785ce29b 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -4900,8 +4900,8 @@ int kvm_tdp_page_fault(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault)
 	return direct_page_fault(vcpu, fault);
 }
 
-static int kvm_tdp_map_page(struct kvm_vcpu *vcpu, gpa_t gpa, u64 error_code,
-			    u8 *level)
+static int kvm_tdp_prefault_page(struct kvm_vcpu *vcpu, gpa_t gpa,
+				 u64 error_code, u8 *level)
 {
 	int r;
 
@@ -4978,7 +4978,7 @@ long kvm_arch_vcpu_pre_fault_memory(struct kvm_vcpu *vcpu,
 	 * Shadow paging uses GVA for kvm page fault, so restrict to
 	 * two-dimensional paging.
 	 */
-	r = kvm_tdp_map_page(vcpu, range->gpa | direct_bits, error_code, &level);
+	r = kvm_tdp_prefault_page(vcpu, range->gpa | direct_bits, error_code, &level);
 	if (r < 0)
 		return r;
 
-- 
2.51.0.268.g9569e192d0-goog

On Tue, 2025-08-26 at 17:05 -0700, Sean Christopherson wrote:
> Rename kvm_tdp_map_page() to kvm_tdp_prefault_page() now that it's used
> only by kvm_arch_vcpu_pre_fault_memory().
> 
> No functional change intended.

I realize you are just trying to do map->prefault here, but "page" seems
redundant once you have "prefault" in the name. Why page here vs all the other
fault handler functions without it?

On Thu, Aug 28, 2025, Rick P Edgecombe wrote:
> On Tue, 2025-08-26 at 17:05 -0700, Sean Christopherson wrote:
> > Rename kvm_tdp_map_page() to kvm_tdp_prefault_page() now that it's used
> > only by kvm_arch_vcpu_pre_fault_memory().
> > 
> > No functional change intended.
> 
> I realize you are just trying to do map->prefault here, but "page" seems
> redundant once you have "prefault" in the name. Why page here vs all the other
> fault handler functions without it?

kvm_tdp_prefault() feels a bit ambiguous/bare.  Many of the fault helpers do have
"page", it's just before the fault part.

  kvm_mmu_finish_page_fault
  kvm_handle_page_fault
  kvm_tdp_page_fault
  direct_page_fault
  nonpaging_page_fault
  kvm_tdp_mmu_page_fault

  (and probably more)

How about kvm_tdp_page_prefault()?  Or kvm_tdp_do_prefault(), but I think I like
kvm_tdp_page_prefault() a little more.

On Thu, 2025-08-28 at 11:50 -0700, Sean Christopherson wrote:
> > 
> > I realize you are just trying to do map->prefault here, but "page" seems
> > redundant once you have "prefault" in the name. Why page here vs all the
> > other fault handler functions without it?
> 
> kvm_tdp_prefault() feels a bit ambiguous/bare.  Many of the fault helpers do
> have "page", it's just before the fault part.
> 
>   kvm_mmu_finish_page_fault
>   kvm_handle_page_fault
>   kvm_tdp_page_fault
>   direct_page_fault
>   nonpaging_page_fault
>   kvm_tdp_mmu_page_fault
> 
>   (and probably more)

True.

> 
> How about kvm_tdp_page_prefault()?  Or kvm_tdp_do_prefault(), but I think I
> like kvm_tdp_page_prefault() a little more.

kvm_tdp_page_prefault() would be my pick of those.