The code indentation for the vchiq interface driver is not so bad
anymore [1], so drop it from the TODO.
Link: https://lore.kernel.org/all/20241013112128.397249-1-umang.jain@ideasonboard.com/ [1]
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
drivers/staging/vc04_services/interface/TODO | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
index f6f24600aa86240fba77169f62f3e657e42727c3..6e5f27db88ba8e533ee1fabc3091771d8efe66a2 100644
--- a/drivers/staging/vc04_services/interface/TODO
+++ b/drivers/staging/vc04_services/interface/TODO
@@ -20,9 +20,3 @@ some of the ones we want:
A short top-down description of this driver's architecture (function of
kthreads, userspace, limitations) could be very helpful for reviewers.
-
-* Reformat core code with more sane indentations
-
-The code follows the 80 characters limitation yet tends to go 3 or 4 levels of
-indentation deep making it very unpleasant to read. This is specially relevant
-in the character driver ioctl code and in the core thread functions.
--
2.50.1
Hi Jai, Am 27.08.25 um 08:24 schrieb Jai Luthra: > The code indentation for the vchiq interface driver is not so bad > anymore [1], so drop it from the TODO. please also drop the point "Import drivers using VCHI." because this is very old (Linux 4.4) and I don't see a reason why this is related to destaging. Best regards > > Link: https://lore.kernel.org/all/20241013112128.397249-1-umang.jain@ideasonboard.com/ [1] > Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/TODO | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index f6f24600aa86240fba77169f62f3e657e42727c3..6e5f27db88ba8e533ee1fabc3091771d8efe66a2 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -20,9 +20,3 @@ some of the ones we want: > > A short top-down description of this driver's architecture (function of > kthreads, userspace, limitations) could be very helpful for reviewers. > - > -* Reformat core code with more sane indentations > - > -The code follows the 80 characters limitation yet tends to go 3 or 4 levels of > -indentation deep making it very unpleasant to read. This is specially relevant > -in the character driver ioctl code and in the core thread functions. >
On Wed, Aug 27, 2025 at 11:54:09AM +0530, Jai Luthra wrote: > The code indentation for the vchiq interface driver is not so bad > anymore [1], so drop it from the TODO. > > Link: https://lore.kernel.org/all/20241013112128.397249-1-umang.jain@ideasonboard.com/ [1] Adding '[1]' at the end doesn't seem to be standard practice and may break automatic parsing. I'd drop that and reword the commit message accordingly. > Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/TODO | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index f6f24600aa86240fba77169f62f3e657e42727c3..6e5f27db88ba8e533ee1fabc3091771d8efe66a2 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -20,9 +20,3 @@ some of the ones we want: > > A short top-down description of this driver's architecture (function of > kthreads, userspace, limitations) could be very helpful for reviewers. > - > -* Reformat core code with more sane indentations > - > -The code follows the 80 characters limitation yet tends to go 3 or 4 levels of > -indentation deep making it very unpleasant to read. This is specially relevant > -in the character driver ioctl code and in the core thread functions. -- Regards, Laurent Pinchart
© 2016 - 2025 Red Hat, Inc.