On Wed, Aug 27, 2025 at 12:59:16PM +0800, Peng Fan wrote:
> MISC protocol supports getting board information. Retrieve the information
> from SM.
>
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> index 220b9369fb537306f9e1a105930ad4d65e6b10aa..f934b4fbc6ec9f1e6b24d1c6c8cd07b45ce548e3 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> @@ -27,6 +27,7 @@ enum scmi_imx_misc_protocol_cmd {
> SCMI_IMX_MISC_CTRL_GET = 0x4,
> SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6,
> SCMI_IMX_MISC_CFG_INFO = 0xC,
> + SCMI_IMX_MISC_BOARD_INFO = 0xE,
Again keep it ordered by command number ?
> SCMI_IMX_MISC_CTRL_NOTIFY = 0x8,
> };
>
> @@ -76,6 +77,12 @@ struct scmi_imx_misc_buildinfo_out {
> u8 buildtime[MISC_MAX_BUILDTIME];
> };
>
> +struct scmi_imx_misc_board_info_out {
> + __le32 attributes;
> +#define MISC_MAX_BRDNAME 16
> + u8 brdname[MISC_MAX_BRDNAME];
> +};
> +
> struct scmi_imx_misc_cfg_info_out {
> __le32 msel;
> #define MISC_MAX_CFGNAME 16
> @@ -316,6 +323,30 @@ static int scmi_imx_misc_discover_build_info(const struct scmi_protocol_handle *
> return ret;
> }
>
> +static int scmi_imx_misc_board_info(const struct scmi_protocol_handle *ph)
> +{
> + struct scmi_imx_misc_board_info_out *out;
> + char name[MISC_MAX_BRDNAME];
> + struct scmi_xfer *t;
> + int ret;
> +
> + ret = ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_BOARD_INFO, 0, sizeof(*out), &t);
> + if (ret)
> + return ret;
> +
> + ret = ph->xops->do_xfer(ph, t);
> + if (!ret) {
> + out = t->rx.buf;
> + strscpy(name, out->brdname, MISC_MAX_BRDNAME);
> + dev_info(ph->dev, "Board\t\t= %s, attr=0x%08x\n",
> + name, le32_to_cpu(out->attributes));
> + }
> +
> + ph->xops->xfer_put(ph, t);
> +
> + return ret;
> +}
> +
> static int scmi_imx_misc_cfg_info(const struct scmi_protocol_handle *ph)
> {
> struct scmi_imx_misc_cfg_info_out *out;
> @@ -371,6 +402,10 @@ static int scmi_imx_misc_protocol_init(const struct scmi_protocol_handle *ph)
> if (ret)
> return ret;
>
> + ret = scmi_imx_misc_board_info(ph);
> + if (ret)
> + return ret;
> +
Ditto, not mandatory, graceful return on NOT_SUPPORTED please.
--
Regards,
Sudeep