There is a long standing bug which causes I2C communication not to
work on the Armada 3700 based boards. The first patch in the series
fixes that regression. The second patch improves recovery to make it
more robust which helps to avoid communication problems with certain
SFP modules.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
Changes in v3:
  - rebase on tip of i2c/for-current
  - remove Imre's tag from the cover letter, and replace his SoB tag to
    Reviewed-by in the individual patches
  - rework the second patch so it does not need changes in the I2C core code,
    and drop the first one as it is not needed now
  - Link to v2: https://lore.kernel.org/r/20250811-i2c-pxa-fix-i2c-communication-v2-0-ca42ea818dc9@gmail.com

Changes in v2:
  - collect offered tags
  - rebase and retest on tip of i2c/for-current
  - Link to v1: https://lore.kernel.org/r/20250511-i2c-pxa-fix-i2c-communication-v1-0-e9097d09a015@gmail.com

---
Gabor Juhos (2):
      i2c: pxa: defer reset on Armada 3700 when recovery is used
      i2c: pxa: handle 'Early Bus Busy' condition on Armada 3700

 drivers/i2c/busses/i2c-pxa.c | 35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)
---
base-commit: 3dd22078026c7cad4d4a3f32c5dc5452c7180de8
change-id: 20250510-i2c-pxa-fix-i2c-communication-3e6de1e3d0c6

Best regards,
-- 
Gabor Juhos <j4g8y7@gmail.com>

On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:
> There is a long standing bug which causes I2C communication not to
> work on the Armada 3700 based boards. The first patch in the series
> fixes that regression. The second patch improves recovery to make it
> more robust which helps to avoid communication problems with certain
> SFP modules.

...

>   - remove Imre's tag from the cover letter, and replace his SoB tag to
>     Reviewed-by in the individual patches

Note, this can be automated with `b4`.

	# Start a new branch of the same base
	git checkout -b v3 ...
	# Apply last version from the mailing list
	b4 am $MESSAGE_ID_OF_v2
	# Do actual development of v3
	...

Also you can do more with `b4 relay`, but I haven't tried it, so I don't know
if it makes it possible or better.

-- 
With Best Regards,
Andy Shevchenko

2025. 09. 01. 11:23 keltezéssel, Andy Shevchenko írta:
> On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:
>> There is a long standing bug which causes I2C communication not to
>> work on the Armada 3700 based boards. The first patch in the series
>> fixes that regression. The second patch improves recovery to make it
>> more robust which helps to avoid communication problems with certain
>> SFP modules.
> 
> ...
> 
>>   - remove Imre's tag from the cover letter, and replace his SoB tag to
>>     Reviewed-by in the individual patches
> 
> Note, this can be automated with `b4`.
> 
> 	# Start a new branch of the same base
> 	git checkout -b v3 ...
> 	# Apply last version from the mailing list
> 	b4 am $MESSAGE_ID_OF_v2
> 	# Do actual development of v3
> 	...

As far as I know it can be used only to collect tags offered publicly on the
mailing lists. I can even use 'b4 trailers --update' for that on an existing b4
tracked branch.

However, the current case is a bit different. I have replaced Imre's tag
manually according to our previous discussion [1].

[1] https://lore.kernel.org/all/aJyM3N9T4xI4Xo1G@smile.fi.intel.com/

Regards,
Gabor

On Mon, Sep 01, 2025 at 05:24:51PM +0200, Gabor Juhos wrote:
> 2025. 09. 01. 11:23 keltezéssel, Andy Shevchenko írta:
> > On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:

...

> >>   - remove Imre's tag from the cover letter, and replace his SoB tag to
> >>     Reviewed-by in the individual patches
> > 
> > Note, this can be automated with `b4`.
> > 
> > 	# Start a new branch of the same base
> > 	git checkout -b v3 ...
> > 	# Apply last version from the mailing list
> > 	b4 am $MESSAGE_ID_OF_v2
> > 	# Do actual development of v3
> > 	...
> 
> As far as I know it can be used only to collect tags offered publicly on the
> mailing lists. I can even use 'b4 trailers --update' for that on an existing b4
> tracked branch.
> 
> However, the current case is a bit different. I have replaced Imre's tag
> manually according to our previous discussion [1].

Right, but technically it can be done via `b4`. I thought you have done that
manually. Seems I misinterpreted things.

> [1] https://lore.kernel.org/all/aJyM3N9T4xI4Xo1G@smile.fi.intel.com/

-- 
With Best Regards,
Andy Shevchenko

On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:
> There is a long standing bug which causes I2C communication not to
> work on the Armada 3700 based boards. The first patch in the series
> fixes that regression. The second patch improves recovery to make it
> more robust which helps to avoid communication problems with certain
> SFP modules.

> Changes in v3:
>   - rebase on tip of i2c/for-current

Hmm... Why not the i2c/i2c-host branch? (It's Andi's tree)

-- 
With Best Regards,
Andy Shevchenko

2025. 09. 01. 11:20 keltezéssel, Andy Shevchenko írta:
> On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:
>> There is a long standing bug which causes I2C communication not to
>> work on the Armada 3700 based boards. The first patch in the series
>> fixes that regression. The second patch improves recovery to make it
>> more robust which helps to avoid communication problems with certain
>> SFP modules.
> 
>> Changes in v3:
>>   - rebase on tip of i2c/for-current
> 
> Hmm... Why not the i2c/i2c-host branch? (It's Andi's tree)
> 

Simply, because the previous versions of the series were based on that since
they contained a patch for the I2C core code. Additionally, I did not notice
that there is a separate tree for host driver patches.

Although, I could send a new version, but that seems pointless since the i2c-pxa
driver code is the same in both trees currently.

Regards,
Gabor

On Mon, Sep 01, 2025 at 04:49:20PM +0200, Gabor Juhos wrote:
> 2025. 09. 01. 11:20 keltezéssel, Andy Shevchenko írta:
> > On Wed, Aug 27, 2025 at 07:13:57PM +0200, Gabor Juhos wrote:
> >> There is a long standing bug which causes I2C communication not to
> >> work on the Armada 3700 based boards. The first patch in the series
> >> fixes that regression. The second patch improves recovery to make it
> >> more robust which helps to avoid communication problems with certain
> >> SFP modules.
> > 
> >> Changes in v3:
> >>   - rebase on tip of i2c/for-current
> > 
> > Hmm... Why not the i2c/i2c-host branch? (It's Andi's tree)
> 
> Simply, because the previous versions of the series were based on that since
> they contained a patch for the I2C core code. Additionally, I did not notice
> that there is a separate tree for host driver patches.
> 
> Although, I could send a new version, but that seems pointless since the i2c-pxa
> driver code is the same in both trees currently.

Yep, no need for a new version (I haven't implied that need). Just asking...

-- 
With Best Regards,
Andy Shevchenko