[PATCH V3 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate

Ram Kumar Dwivedi posted 4 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH V3 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate
Posted by Ram Kumar Dwivedi 1 month, 1 week ago
Add support to limit Tx/Rx gear and rate during UFS initialization
based on DT property.

Also update the phy_gear to ensure PHY calibrations align with
the required gear and rate.

Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
---
 drivers/ufs/host/ufs-qcom.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 1a93351fb70e..53c64d5fb95d 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1092,6 +1092,18 @@ static void ufs_qcom_set_phy_gear(struct ufs_qcom_host *host)
 	}
 }
 
+static void ufs_qcom_parse_limits(struct ufs_hba *hba)
+{
+	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
+	struct ufs_host_params *host_params = &host->host_params;
+	u32 hs_gear_old = host_params->hs_tx_gear;
+
+	ufshcd_parse_limits(hba, host_params);
+	if (host_params->hs_tx_gear != hs_gear_old) {
+		host->phy_gear = host_params->hs_tx_gear;
+	}
+}
+
 static void ufs_qcom_set_host_params(struct ufs_hba *hba)
 {
 	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
@@ -1333,6 +1345,7 @@ static int ufs_qcom_init(struct ufs_hba *hba)
 	ufs_qcom_advertise_quirks(hba);
 	ufs_qcom_set_host_params(hba);
 	ufs_qcom_set_phy_gear(host);
+	ufs_qcom_parse_limits(hba);
 
 	err = ufs_qcom_ice_init(host);
 	if (err)
-- 
2.50.1
Re: [PATCH V3 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate
Posted by Bart Van Assche 1 month, 1 week ago
On 8/26/25 8:08 AM, Ram Kumar Dwivedi wrote:
> +	if (host_params->hs_tx_gear != hs_gear_old) {
> +		host->phy_gear = host_params->hs_tx_gear;
> +	}

The recommended style in Linux kernel code is not to surround single
statements with braces.

Thanks,

Bart.
Re: [PATCH V3 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate
Posted by Ram Kumar Dwivedi 1 month ago

On 26-Aug-25 9:07 PM, Bart Van Assche wrote:
> On 8/26/25 8:08 AM, Ram Kumar Dwivedi wrote:
>> +    if (host_params->hs_tx_gear != hs_gear_old) {
>> +        host->phy_gear = host_params->hs_tx_gear;
>> +    }
> 
> The recommended style in Linux kernel code is not to surround single
> statements with braces.
> 
Hi Bart,

Sure, I will update it in the next patchset.

Thanks,
Ram> Thanks,
> 
> Bart.