drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 68 +++++++++++++++---- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 19 +++++- include/linux/stmmac.h | 1 + 5 files changed, 76 insertions(+), 15 deletions(-)
This series starts with three fixes addressing KASAN panic on ethtool usage, Enhanced Descriptor printing and flow stop on TC block setup when interface down. Everything that follows adds new features such as ARP Offload support, VLAN protocol detection and TC flower filter support. Karol Jurczenia (4): net: stmmac: check if interface is running before TC block setup net: stmmac: enable ARP Offload on mac_link_up() net: stmmac: set TE/RE bits for ARP Offload when interface down net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski (1): net: stmmac: replace memcpy with strscpy in ethtool Piotr Warpechowski (2): net: stmmac: correct Tx descriptors debugfs prints net: stmmac: enhance VLAN protocol detection for GRO drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 68 +++++++++++++++---- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 19 +++++- include/linux/stmmac.h | 1 + 5 files changed, 76 insertions(+), 15 deletions(-) -- 2.34.1
On 26/08/2025 12:32, Konrad Leszczynski wrote: > This series starts with three fixes addressing KASAN panic on ethtool > usage, Enhanced Descriptor printing and flow stop on TC block setup when > interface down. > Everything that follows adds new features such as ARP Offload support, > VLAN protocol detection and TC flower filter support. Well, mixing fixes and features in one patchset is not a great idea. Fixes patches should have Fixes: tags and go to -net tree while features should go to net-next. It's better to split series into 2 and provide proper tags for the "fixes" part
On 26-Aug-25 19:29, Vadim Fedorenko wrote: > On 26/08/2025 12:32, Konrad Leszczynski wrote: >> This series starts with three fixes addressing KASAN panic on ethtool >> usage, Enhanced Descriptor printing and flow stop on TC block setup when >> interface down. >> Everything that follows adds new features such as ARP Offload support, >> VLAN protocol detection and TC flower filter support. > > Well, mixing fixes and features in one patchset is not a great idea. > Fixes patches should have Fixes: tags and go to -net tree while features > should go to net-next. It's better to split series into 2 and provide > proper tags for the "fixes" part Hi Vadim, Thanks for the review. I've specifically placed the fixes first and the features afterwards to not intertwine the patches. I can split them into two patchsets if you think that's the best way to go.
On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote:
>
> On 26-Aug-25 19:29, Vadim Fedorenko wrote:
> > On 26/08/2025 12:32, Konrad Leszczynski wrote:
> > > This series starts with three fixes addressing KASAN panic on ethtool
> > > usage, Enhanced Descriptor printing and flow stop on TC block setup when
> > > interface down.
> > > Everything that follows adds new features such as ARP Offload support,
> > > VLAN protocol detection and TC flower filter support.
> >
> > Well, mixing fixes and features in one patchset is not a great idea.
> > Fixes patches should have Fixes: tags and go to -net tree while features
> > should go to net-next. It's better to split series into 2 and provide
> > proper tags for the "fixes" part
>
> Hi Vadim,
>
> Thanks for the review. I've specifically placed the fixes first and the
> features afterwards to not intertwine the patches. I can split them into two
> patchsets if you think that's the best way to go.
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
You probably need to wait a week between the fixes and new features in
order that net and net-next are synced.
Andrew
---
pw-bot: cr
On 28-Aug-25 14:25, Andrew Lunn wrote: > On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote: >> On 26-Aug-25 19:29, Vadim Fedorenko wrote: >>> On 26/08/2025 12:32, Konrad Leszczynski wrote: >>>> This series starts with three fixes addressing KASAN panic on ethtool >>>> usage, Enhanced Descriptor printing and flow stop on TC block setup when >>>> interface down. >>>> Everything that follows adds new features such as ARP Offload support, >>>> VLAN protocol detection and TC flower filter support. >>> Well, mixing fixes and features in one patchset is not a great idea. >>> Fixes patches should have Fixes: tags and go to -net tree while features >>> should go to net-next. It's better to split series into 2 and provide >>> proper tags for the "fixes" part >> Hi Vadim, >> >> Thanks for the review. I've specifically placed the fixes first and the >> features afterwards to not intertwine the patches. I can split them into two >> patchsets if you think that's the best way to go. > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html > > You probably need to wait a week between the fixes and new features in > order that net and net-next are synced. > > Andrew > > --- > pw-bot: cr > Hi Andrew. Thanks for the heads-up. Fixes are new features are independent from each other. Should I still wait a week to send out the patchset containing the new features? Konrad
On Thu, Aug 28, 2025 at 02:51:51PM +0200, Konrad Leszczynski wrote:
>
> On 28-Aug-25 14:25, Andrew Lunn wrote:
> > On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote:
> > > On 26-Aug-25 19:29, Vadim Fedorenko wrote:
> > > > On 26/08/2025 12:32, Konrad Leszczynski wrote:
> > > > > This series starts with three fixes addressing KASAN panic on ethtool
> > > > > usage, Enhanced Descriptor printing and flow stop on TC block setup when
> > > > > interface down.
> > > > > Everything that follows adds new features such as ARP Offload support,
> > > > > VLAN protocol detection and TC flower filter support.
> > > > Well, mixing fixes and features in one patchset is not a great idea.
> > > > Fixes patches should have Fixes: tags and go to -net tree while features
> > > > should go to net-next. It's better to split series into 2 and provide
> > > > proper tags for the "fixes" part
> > > Hi Vadim,
> > >
> > > Thanks for the review. I've specifically placed the fixes first and the
> > > features afterwards to not intertwine the patches. I can split them into two
> > > patchsets if you think that's the best way to go.
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> >
> > You probably need to wait a week between the fixes and new features in
> > order that net and net-next are synced.
> >
> > Andrew
> >
> > ---
> > pw-bot: cr
> >
>
> Hi Andrew. Thanks for the heads-up. Fixes are new features are independent
> from each other. Should I still wait a week to send out the patchset
> containing the new features?
What you want to avoid is causing the netdev Maintainers to resolve
merge conflicts when net-next and net are merged. By waiting a week,
you get to resolve such conflicts.
Andrew
On 28/08/2025 13:51, Konrad Leszczynski wrote: > > On 28-Aug-25 14:25, Andrew Lunn wrote: >> On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote: >>> On 26-Aug-25 19:29, Vadim Fedorenko wrote: >>>> On 26/08/2025 12:32, Konrad Leszczynski wrote: >>>>> This series starts with three fixes addressing KASAN panic on ethtool >>>>> usage, Enhanced Descriptor printing and flow stop on TC block setup >>>>> when >>>>> interface down. >>>>> Everything that follows adds new features such as ARP Offload support, >>>>> VLAN protocol detection and TC flower filter support. >>>> Well, mixing fixes and features in one patchset is not a great idea. >>>> Fixes patches should have Fixes: tags and go to -net tree while >>>> features >>>> should go to net-next. It's better to split series into 2 and provide >>>> proper tags for the "fixes" part >>> Hi Vadim, >>> >>> Thanks for the review. I've specifically placed the fixes first and the >>> features afterwards to not intertwine the patches. I can split them >>> into two >>> patchsets if you think that's the best way to go. >> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html >> >> You probably need to wait a week between the fixes and new features in >> order that net and net-next are synced. >> >> Andrew >> >> --- >> pw-bot: cr >> > > Hi Andrew. Thanks for the heads-up. Fixes are new features are > independent from each other. Should I still wait a week to send out the > patchset containing the new features? If they are totally independent then there is no reason to wait for a week. But be sure to base fixes on top of net.git while features on top of net-next.git and put appropriate prefix in the patch subject.
© 2016 - 2025 Red Hat, Inc.