perf trace: Use consistent print_opts formatting in trace__fprintf_callchain()

[PATCH] perf trace: Use consistent print_opts formatting in trace__fprintf_callchain()

Posted by Ahmed Atef El-Emary 1 month, 1 week ago

trace__fprintf_callchain() previously omitted IP and symoffset from its
print_opts, unlike other callchain printers in perf. This resulted in
less detailed and inconsistent callchain output.

Add EVSEL__PRINT_IP and EVSEL__PRINT_SYMOFFSET to make the output more
consistent and informative. The callchain output now includes IP, symbol
offset, DSO, and falls back to the raw address when no symbol is found,
matching the detail level of other perf callchain outputs.

Signed-off-by: Ahmed Atef El-Emary <ahmed.software.engineer1@gmail.com>
---
 tools/perf/builtin-trace.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index fe737b3ac6e6..20f3488d4a21 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2892,8 +2892,10 @@ static int trace__fprintf_callchain(struct trace *trace, struct perf_sample *sam
 {
 	/* TODO: user-configurable print_opts */
 	const unsigned int print_opts = EVSEL__PRINT_SYM |
-				        EVSEL__PRINT_DSO |
-				        EVSEL__PRINT_UNKNOWN_AS_ADDR;
+				EVSEL__PRINT_DSO |
+				EVSEL__PRINT_UNKNOWN_AS_ADDR |
+				EVSEL__PRINT_IP |
+				EVSEL__PRINT_SYMOFFSET;
 
 	return sample__fprintf_callchain(sample, 38, print_opts, get_tls_callchain_cursor(), symbol_conf.bt_stop_list, trace->output);
 }
-- 
2.43.0

Re: [PATCH] perf trace: Use consistent print_opts formatting in trace__fprintf_callchain()

Posted by Arnaldo Carvalho de Melo 2 weeks, 6 days ago

On Tue, Aug 26, 2025 at 11:08:11AM +0300, Ahmed Atef El-Emary wrote:
> trace__fprintf_callchain() previously omitted IP and symoffset from its
> print_opts, unlike other callchain printers in perf. This resulted in
> less detailed and inconsistent callchain output.
> 
> Add EVSEL__PRINT_IP and EVSEL__PRINT_SYMOFFSET to make the output more
> consistent and informative. The callchain output now includes IP, symbol
> offset, DSO, and falls back to the raw address when no symbol is found,
> matching the detail level of other perf callchain outputs.

Can you please exemplify before and after output in addition of just
describing the changes?

- Arnaldo
 
> Signed-off-by: Ahmed Atef El-Emary <ahmed.software.engineer1@gmail.com>
> ---
>  tools/perf/builtin-trace.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index fe737b3ac6e6..20f3488d4a21 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -2892,8 +2892,10 @@ static int trace__fprintf_callchain(struct trace *trace, struct perf_sample *sam
>  {
>  	/* TODO: user-configurable print_opts */
>  	const unsigned int print_opts = EVSEL__PRINT_SYM |
> -				        EVSEL__PRINT_DSO |
> -				        EVSEL__PRINT_UNKNOWN_AS_ADDR;
> +				EVSEL__PRINT_DSO |
> +				EVSEL__PRINT_UNKNOWN_AS_ADDR |
> +				EVSEL__PRINT_IP |
> +				EVSEL__PRINT_SYMOFFSET;
>  
>  	return sample__fprintf_callchain(sample, 38, print_opts, get_tls_callchain_cursor(), symbol_conf.bt_stop_list, trace->output);
>  }
> -- 
> 2.43.0