Binding values for special resets that are placed starting from
software-defined index 160 in line with other chips.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 include/dt-bindings/reset/tegra114-car.h

diff --git a/include/dt-bindings/reset/tegra114-car.h b/include/dt-bindings/reset/tegra114-car.h
new file mode 100644
index 000000000000..d7908d810ddf
--- /dev/null
+++ b/include/dt-bindings/reset/tegra114-car.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
+/*
+ * This header provides Tegra114-specific constants for binding
+ * nvidia,tegra114-car.
+ */
+
+#ifndef _DT_BINDINGS_RESET_TEGRA114_CAR_H
+#define _DT_BINDINGS_RESET_TEGRA114_CAR_H
+
+#define TEGRA114_RESET(x)		(5 * 32 + (x))
+#define TEGRA114_RST_DFLL_DVCO		TEGRA114_RESET(0)
+
+#endif	/* _DT_BINDINGS_RESET_TEGRA114_CAR_H */
-- 
2.48.1

On 26/08/2025 08:11, Svyatoslav Ryhel wrote:
> Binding values for special resets that are placed starting from
> software-defined index 160 in line with other chips.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
NAK

You got comments last time and you completely ignored them.

Best regards,
Krzysztof

On Tuesday, August 26, 2025 5:21 PM Krzysztof Kozlowski wrote:
> On 26/08/2025 08:11, Svyatoslav Ryhel wrote:
> > Binding values for special resets that are placed starting from
> > software-defined index 160 in line with other chips.
> > 
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > 
> >  include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
> 
> NAK
> 
> You got comments last time and you completely ignored them.
> 
> Best regards,
> Krzysztof

Thierry explained to you last time why this patch makes sense.

The existing binding is such that values below 160 map to clock IDs (in dt-
bindings/clock/tegra114-car.h). We cannot use those numbers for these "special 
resets" that have no corresponding clock, or we'd be changing existing 
binding. Hence this patch starts them at 160, above the clock IDs. The same 
already exists in the tegra124-car binding for TEGRA124_RST_DFLL_DVCO -- this 
just extends that to Tegra114.

Mikko

On 26/08/2025 10:29, Mikko Perttunen wrote:
> On Tuesday, August 26, 2025 5:21 PM Krzysztof Kozlowski wrote:
>> On 26/08/2025 08:11, Svyatoslav Ryhel wrote:
>>> Binding values for special resets that are placed starting from
>>> software-defined index 160 in line with other chips.
>>>
>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>> ---
>>>
>>>  include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
>>
>> NAK
>>
>> You got comments last time and you completely ignored them.
>>
>> Best regards,
>> Krzysztof
> 
> Thierry explained to you last time why this patch makes sense.

And each such discussion should be reflected in the commit msg. There is
nothing like that here.

But I am not speaking about this and the values here. I am speaking
about all other comments which were just ignored.


Best regards,
Krzysztof