On Mon, Aug 25, 2025 at 07:54:06PM +0000, Zecheng Li wrote:
> Introduce a helper function is_address_gen_insn() to check
> arch-dependent address generation instructions like lea in x86. Remove
> type annotation on these instructions since they are not accessing
> memory. It should be counted as `no_mem_ops`.
>
> Signed-off-by: Zecheng Li <zecheng@google.com>
> ---
> tools/perf/util/annotate.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 0dd475a744b6..9d36709d867d 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -2621,6 +2621,19 @@ static bool is_stack_canary(struct arch *arch, struct annotated_op_loc *loc)
> return false;
> }
>
> +/**
> + * Returns true if the instruction has a memory operand without
> + * performing a load/store
> + */
> +static bool is_address_gen_insn(struct arch *arch, struct disasm_line *dl)
> +{
> + if (arch__is(arch, "x86"))
> + if (!strncmp(dl->ins.name, "lea", 3))
> + return true;
> +
> + return false;
> +}
> +
> static struct disasm_line *
> annotation__prev_asm_line(struct annotation *notes, struct disasm_line *curr)
> {
> @@ -2729,6 +2742,11 @@ __hist_entry__get_data_type(struct hist_entry *he, struct arch *arch,
> return &stackop_type;
> }
>
> + if (is_address_gen_insn(arch, dl)) {
> + istat->bad++;
> + return NULL;
Do you return NULL because you want to handle it with no_mem_ops case?
I suggest you add it here and return NO_TYPE. There are places to call
__hist_entry__get_data_type() directly and I'd like to update the stat
in this function as much as possible.
Thanks,
Namhyung
> + }
> +
> for_each_insn_op_loc(&loc, i, op_loc) {
> struct data_loc_info dloc = {
> .arch = arch,
> --
> 2.51.0.261.g7ce5a0a67e-goog
>