[PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers

Alex Williamson posted 2 patches 1 month, 1 week ago
drivers/vfio/platform/Kconfig                            | 5 ++++-
drivers/vfio/platform/reset/Kconfig                      | 6 +++---
drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
drivers/vfio/platform/vfio_amba.c                        | 2 ++
6 files changed, 15 insertions(+), 4 deletions(-)
[PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers
Posted by Alex Williamson 1 month, 1 week ago
Based on discussion[1] there's still interest in keeping vfio-platform
itself, but the use case doesn't involve any of the current reset
drivers and doesn't include vfio-amba.  To give any users a chance to
speak up, let's mark these as deprecated and generate logs if they're
used.

I intend to pull the vfio/fsl-mc removal from the previous series given
there were no objections.  Thanks,

Alex

[1] https://lore.kernel.org/all/20250806170314.3768750-1-alex.williamson@redhat.com/

Alex Williamson (2):
  vfio/amba: Mark for removal
  vfio/platform: Mark reset drivers for removal

 drivers/vfio/platform/Kconfig                            | 5 ++++-
 drivers/vfio/platform/reset/Kconfig                      | 6 +++---
 drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
 drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
 drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
 drivers/vfio/platform/vfio_amba.c                        | 2 ++
 6 files changed, 15 insertions(+), 4 deletions(-)

-- 
2.50.1
Re: [PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers
Posted by Pranjal Shrivastava 1 month ago
On Mon, Aug 25, 2025 at 11:57:59AM -0600, Alex Williamson wrote:
> Based on discussion[1] there's still interest in keeping vfio-platform
> itself, but the use case doesn't involve any of the current reset
> drivers and doesn't include vfio-amba.  To give any users a chance to
> speak up, let's mark these as deprecated and generate logs if they're
> used.
> 
> I intend to pull the vfio/fsl-mc removal from the previous series given
> there were no objections.  Thanks,
> 
> Alex
> 
> [1] https://lore.kernel.org/all/20250806170314.3768750-1-alex.williamson@redhat.com/
> 
> Alex Williamson (2):
>   vfio/amba: Mark for removal
>   vfio/platform: Mark reset drivers for removal
> 
>  drivers/vfio/platform/Kconfig                            | 5 ++++-
>  drivers/vfio/platform/reset/Kconfig                      | 6 +++---
>  drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
>  drivers/vfio/platform/vfio_amba.c                        | 2 ++
>  6 files changed, 15 insertions(+), 4 deletions(-)
> 

The series feels like a sensible compromise. The rationale for
deprecating vfio-amba and the obsolete reset drivers is sound, as it
cleans up code that can no longer be tested by the maintainers [1].

The changes to Kconfig and the addition of dev_err_once() handle this
deprecation cleanly.

For the series:
Reviewed-by: Pranjal Shrivastava <praan@google.com>

Thanks,
Praan

[1] https://kvm-forum.qemu.org/2024/vfio-platform-kvm-forum24-landscape_TtZ3SnC.pdf

> -- 
> 2.50.1
>
Re: [PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers
Posted by Mostafa Saleh 1 month ago
Hi Alex,

On Mon, Aug 25, 2025 at 11:57:59AM -0600, Alex Williamson wrote:
> Based on discussion[1] there's still interest in keeping vfio-platform
> itself, but the use case doesn't involve any of the current reset
> drivers and doesn't include vfio-amba.  To give any users a chance to
> speak up, let's mark these as deprecated and generate logs if they're
> used.
> 
> I intend to pull the vfio/fsl-mc removal from the previous series given
> there were no objections.  Thanks,
> 
> Alex
> 
> [1] https://lore.kernel.org/all/20250806170314.3768750-1-alex.williamson@redhat.com/
> 
> Alex Williamson (2):
>   vfio/amba: Mark for removal
>   vfio/platform: Mark reset drivers for removal
> 
>  drivers/vfio/platform/Kconfig                            | 5 ++++-
>  drivers/vfio/platform/reset/Kconfig                      | 6 +++---
>  drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
>  drivers/vfio/platform/vfio_amba.c                        | 2 ++
>  6 files changed, 15 insertions(+), 4 deletions(-)

For the series:
Reviewed-by: Mostafa Saleh <smostafa@google.com>

Thanks,
Mostafa

> 
> -- 
> 2.50.1
>
Re: [PATCH 0/2] vfio/platform: Deprecate vfio-amba and reset drivers
Posted by Eric Auger 1 month, 1 week ago

On 8/25/25 7:57 PM, Alex Williamson wrote:
> Based on discussion[1] there's still interest in keeping vfio-platform
> itself, but the use case doesn't involve any of the current reset
> drivers and doesn't include vfio-amba.  To give any users a chance to
> speak up, let's mark these as deprecated and generate logs if they're
> used.
>
> I intend to pull the vfio/fsl-mc removal from the previous series given
> there were no objections.  Thanks,
>
> Alex
>
> [1] https://lore.kernel.org/all/20250806170314.3768750-1-alex.williamson@redhat.com/
for the series:
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
>
> Alex Williamson (2):
>   vfio/amba: Mark for removal
>   vfio/platform: Mark reset drivers for removal
>
>  drivers/vfio/platform/Kconfig                            | 5 ++++-
>  drivers/vfio/platform/reset/Kconfig                      | 6 +++---
>  drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 ++
>  drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 ++
>  drivers/vfio/platform/vfio_amba.c                        | 2 ++
>  6 files changed, 15 insertions(+), 4 deletions(-)
>