[PATCH v2 0/3] floppy: A couple of cleanups

Andy Shevchenko posted 3 patches 1 month, 1 week ago
arch/alpha/include/asm/floppy.h    | 19 ----------
arch/arm/include/asm/floppy.h      |  2 --
arch/m68k/include/asm/floppy.h     |  4 ---
arch/mips/include/asm/floppy.h     | 15 --------
arch/parisc/include/asm/floppy.h   | 11 +++---
arch/powerpc/include/asm/floppy.h  |  5 ---
arch/sparc/include/asm/floppy_32.h |  3 --
arch/sparc/include/asm/floppy_64.h |  3 --
arch/x86/include/asm/floppy.h      |  8 ++---
drivers/block/floppy.c             | 56 ++++++++++++++----------------
10 files changed, 34 insertions(+), 92 deletions(-)
[PATCH v2 0/3] floppy: A couple of cleanups
Posted by Andy Shevchenko 1 month, 1 week ago
There are a few places in architecture code for the floppy driver
that may be cleaned up. Do it so.

Assumed to route via Andrew Morton's tree as floppy is basically orphaned.

Changelog v2:
- combined separate patches sent earlier into a series
- added tags (Helge, Geert)
- fixed typo in the commit message (Geert)

Andy Shevchenko (3):
  floppy: Remove unused CROSS_64KB() macro from arch/ code
  floppy: Replace custom SZ_64K constant
  floppy: Sort headers alphabetically

 arch/alpha/include/asm/floppy.h    | 19 ----------
 arch/arm/include/asm/floppy.h      |  2 --
 arch/m68k/include/asm/floppy.h     |  4 ---
 arch/mips/include/asm/floppy.h     | 15 --------
 arch/parisc/include/asm/floppy.h   | 11 +++---
 arch/powerpc/include/asm/floppy.h  |  5 ---
 arch/sparc/include/asm/floppy_32.h |  3 --
 arch/sparc/include/asm/floppy_64.h |  3 --
 arch/x86/include/asm/floppy.h      |  8 ++---
 drivers/block/floppy.c             | 56 ++++++++++++++----------------
 10 files changed, 34 insertions(+), 92 deletions(-)

-- 
2.50.1
Re: [PATCH v2 0/3] floppy: A couple of cleanups
Posted by Jens Axboe 1 month, 1 week ago
On Mon, 25 Aug 2025 18:32:54 +0200, Andy Shevchenko wrote:
> There are a few places in architecture code for the floppy driver
> that may be cleaned up. Do it so.
> 
> Assumed to route via Andrew Morton's tree as floppy is basically orphaned.
> 
> Changelog v2:
> - combined separate patches sent earlier into a series
> - added tags (Helge, Geert)
> - fixed typo in the commit message (Geert)
> 
> [...]

Applied, thanks!

[1/3] floppy: Remove unused CROSS_64KB() macro from arch/ code
      commit: d74968780bf287958e2815be5f088dd6c7b7aa19
[2/3] floppy: Replace custom SZ_64K constant
      commit: 8e7ee0f6fa33934373c1c37e8cfb71cff2acea09
[3/3] floppy: Sort headers alphabetically
      commit: d4399e6eb27a803b73d17fe984448a823b4d3a30

Best regards,
-- 
Jens Axboe
Re: [PATCH v2 0/3] floppy: A couple of cleanups
Posted by Andy Shevchenko 1 month, 1 week ago
On Mon, Aug 25, 2025 at 02:48:21PM -0600, Jens Axboe wrote:
> On Mon, 25 Aug 2025 18:32:54 +0200, Andy Shevchenko wrote:
> > There are a few places in architecture code for the floppy driver
> > that may be cleaned up. Do it so.
> > 
> > Assumed to route via Andrew Morton's tree as floppy is basically orphaned.
> > 
> > Changelog v2:
> > - combined separate patches sent earlier into a series
> > - added tags (Helge, Geert)
> > - fixed typo in the commit message (Geert)

[...]

> Applied, thanks!

Ah, thanks! It's good to know you can take (and actually did that) them.

> [1/3] floppy: Remove unused CROSS_64KB() macro from arch/ code
>       commit: d74968780bf287958e2815be5f088dd6c7b7aa19
> [2/3] floppy: Replace custom SZ_64K constant
>       commit: 8e7ee0f6fa33934373c1c37e8cfb71cff2acea09
> [3/3] floppy: Sort headers alphabetically
>       commit: d4399e6eb27a803b73d17fe984448a823b4d3a30

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/3] floppy: A couple of cleanups
Posted by Jens Axboe 1 month, 1 week ago
On 8/26/25 7:28 AM, Andy Shevchenko wrote:
> On Mon, Aug 25, 2025 at 02:48:21PM -0600, Jens Axboe wrote:
>> On Mon, 25 Aug 2025 18:32:54 +0200, Andy Shevchenko wrote:
>>> There are a few places in architecture code for the floppy driver
>>> that may be cleaned up. Do it so.
>>>
>>> Assumed to route via Andrew Morton's tree as floppy is basically orphaned.
>>>
>>> Changelog v2:
>>> - combined separate patches sent earlier into a series
>>> - added tags (Helge, Geert)
>>> - fixed typo in the commit message (Geert)
> 
> [...]
> 
>> Applied, thanks!
> 
> Ah, thanks! It's good to know you can take (and actually did that) them.

I've always been happy to apply floppy fixes or cleanups, I just treat
it like any other orhpaned/unmaintained block driver.

-- 
Jens Axboe