[PATCH v2] clk: mediatek: clk-mux: Do not pass flags to clk_mux_determine_rate_flags()

Chen-Yu Tsai posted 1 patch 1 month, 1 week ago
drivers/clk/mediatek/clk-mux.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH v2] clk: mediatek: clk-mux: Do not pass flags to clk_mux_determine_rate_flags()
Posted by Chen-Yu Tsai 1 month, 1 week ago
The `flags` in |struct mtk_mux| are core clk flags, not mux clk flags.
Passing one to the other is wrong.

Since there aren't any actual users adding CLK_MUX_* flags, just drop it
for now.

Fixes: b05ea3314390 ("clk: mediatek: clk-mux: Add .determine_rate() callback")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes since v1:
- Dropped unused variable
---
 drivers/clk/mediatek/clk-mux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c
index 60990296450b..9a12e58230be 100644
--- a/drivers/clk/mediatek/clk-mux.c
+++ b/drivers/clk/mediatek/clk-mux.c
@@ -146,9 +146,7 @@ static int mtk_clk_mux_set_parent_setclr_lock(struct clk_hw *hw, u8 index)
 static int mtk_clk_mux_determine_rate(struct clk_hw *hw,
 				      struct clk_rate_request *req)
 {
-	struct mtk_clk_mux *mux = to_mtk_clk_mux(hw);
-
-	return clk_mux_determine_rate_flags(hw, req, mux->data->flags);
+	return clk_mux_determine_rate_flags(hw, req, 0);
 }
 
 const struct clk_ops mtk_mux_clr_set_upd_ops = {
-- 
2.51.0.261.g7ce5a0a67e-goog
Re: [PATCH v2] clk: mediatek: clk-mux: Do not pass flags to clk_mux_determine_rate_flags()
Posted by Stephen Boyd 1 week, 5 days ago
Quoting Chen-Yu Tsai (2025-08-25 08:09:31)
> The `flags` in |struct mtk_mux| are core clk flags, not mux clk flags.
> Passing one to the other is wrong.
> 
> Since there aren't any actual users adding CLK_MUX_* flags, just drop it
> for now.
> 
> Fixes: b05ea3314390 ("clk: mediatek: clk-mux: Add .determine_rate() callback")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---

Applied to clk-next