On 8/25/25 03:34, Kuan-Wei Chiu wrote:
> The comparison function used to sort stack trace locations in debugfs
> never relied on the third argument. Therefore, sort_r() is unnecessary.
> Switch to sort() with a two-argument comparison function to keep the
> code simple and aligned with the intended usage.
>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
LGTM.
> ---
> mm/slub.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index c91b3744adbc..67b68f132f84 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -7711,7 +7711,7 @@ static void *slab_debugfs_next(struct seq_file *seq, void *v, loff_t *ppos)
> return NULL;
> }
>
> -static int cmp_loc_by_count(const void *a, const void *b, const void *data)
> +static int cmp_loc_by_count(const void *a, const void *b)
> {
> struct location *loc1 = (struct location *)a;
> struct location *loc2 = (struct location *)b;
> @@ -7782,8 +7782,8 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep)
> }
>
> /* Sort locations by count */
> - sort_r(t->loc, t->count, sizeof(struct location),
> - cmp_loc_by_count, NULL, NULL);
> + sort(t->loc, t->count, sizeof(struct location),
> + cmp_loc_by_count, NULL);
>
> bitmap_free(obj_map);
> return 0;