iio: mcp9600: Implement IIR feature and add iio core support

[PATCH v7 0/5] iio: mcp9600: Implement IIR feature and add iio core support

Posted by Ben Collins 1 month, 1 week ago

ChangeLog:
v6 -> v7:
  - Remove extra space before trailing \
  - Don't add extra white-space
  - Remove mcp9600_write_raw_get_fmt
  - Separate out the mcp9600 IIR series into its own series as there is
    a lot of conversation around implementation.
  - Add rework of ad4080 to match filter_type "none" logic

v5 -> v6:
  - Cleanup tabs that were converted to spaces

v4 -> v5:
  - Missed a one line fix to IIR patch (5/5)

v3 -> v4:
  - Based on lots of feedback, use frequency values for IIR, and use
    filter_type[none, ema] to enable or disable.

v2 -> v3:
  - Improve changelogs in each patch
  - Based on feedback from Andy Shevchenko <andy.shevchenko@gmail.com>
    * Fix typos
    * FIELD_PREP -> FIELD_MODIFY
    * Remove explicit setting of 0 value in filter_level
  - Based on feedback from David Lechner <dlechner@baylibre.com>
    * Rework IIR values exposed to sysfs. Using the ratios, there was no
      way to represent "disabled" (i.e. infinity). Based on the bmp280
      driver I went with using the power coefficients (e.g. 1, 2, 4, 8,
      ...) where 1 is disabled (n=0).

v1 -> v2:
  - Break into individual patches

v1:
  - Initial patch to enable IIR and thermocouple-type
  - Recognize mcp9601

Signed-off-by: Ben Collins <bcollins@kernel.org>
---
Ben Collins (5):
      iio: core: Add IIO_VAL_EMPTY type
      ABI: sysfs-bus-iio: Disambiguate usage for filter_type "none"
      ABI: sysfs-bus-iio: Document "ema" filter_type
      iio: mcp9600: Add support for IIR filter
      iio: ad4080: Rework filter_type "none" logic

 Documentation/ABI/testing/sysfs-bus-iio |   8 +-
 drivers/iio/adc/ad4080.c                |  23 +++--
 drivers/iio/industrialio-core.c         |   1 +
 drivers/iio/temperature/mcp9600.c       | 147 ++++++++++++++++++++++++++++++++
 include/linux/iio/types.h               |   1 +
 5 files changed, 166 insertions(+), 14 deletions(-)
---
base-commit: c17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
change-id: 20250819-mcp9600-iir-8f7ff1ad0804
prerequisite-change-id: 20250819-upstream-changes-c89af86743fa:v8
prerequisite-patch-id: 92882274615d59f2e89c189ce0859297fca88772
prerequisite-patch-id: d2c1fd9da2dee3ad5dc240f34cc108d02980a4c5
prerequisite-patch-id: 72368205aaa96b053ba78ffe6548d0895e039753
prerequisite-patch-id: 98a8a8ee92fc0a9836975d5b216d41702860019a
prerequisite-patch-id: c24cb6dd5b2b385c00bffdbf1f7a61e4d1532f49

Best regards,
-- 
Ben Collins <bcollins@kernel.org>

Re: [PATCH v7 0/5] iio: mcp9600: Implement IIR feature and add iio core support

Posted by Andy Shevchenko 1 month, 1 week ago

On Tue, Aug 26, 2025 at 3:10 AM Ben Collins <bcollins@kernel.org> wrote:
>
> ChangeLog:
> v6 -> v7:
>   - Remove extra space before trailing \
>   - Don't add extra white-space
>   - Remove mcp9600_write_raw_get_fmt
>   - Separate out the mcp9600 IIR series into its own series as there is
>     a lot of conversation around implementation.
>   - Add rework of ad4080 to match filter_type "none" logic

Wasn't v6 already applied?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v7 0/5] iio: mcp9600: Implement IIR feature and add iio core support

Posted by Ben Collins 1 month, 1 week ago

On Tue, Aug 26, 2025 at 11:14:58AM -0500, Andy Shevchenko wrote:
> On Tue, Aug 26, 2025 at 3:10 AM Ben Collins <bcollins@kernel.org> wrote:
> >
> > ChangeLog:
> > v6 -> v7:
> >   - Remove extra space before trailing \
> >   - Don't add extra white-space
> >   - Remove mcp9600_write_raw_get_fmt
> >   - Separate out the mcp9600 IIR series into its own series as there is
> >     a lot of conversation around implementation.
> >   - Add rework of ad4080 to match filter_type "none" logic
> 
> Wasn't v6 already applied?

v8 of the mcp9600 feature patch series was. This is the IIR series, of
which, none of it has been accepted, yet.

-- 
 Ben Collins
 https://libjwt.io
 https://github.com/benmcollins
 --
 3EC9 7598 1672 961A 1139  173A 5D5A 57C7 242B 22CF