On Mon, Aug 25, 2025 at 04:36:42PM +0800, Peng Fan wrote:
> The TJA1051 is a high-speed CAN transceiver which is a pin-compatible
> alternative for TI TCAN1043 with Sleep mode supported, and has a compatible
> programming model, therefore use ti,tcan1043 as fallback compatible.
>
> The TJA1048 is a dual high-speed CAN transceiver with Sleep mode supported.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 33 ++++++++++++++++++++--
> 1 file changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 4a8c3829d85d3c4a4963750d03567c1c345beb91..3ae08815225d82b6a09cf8a6deacadbddf781fed 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -19,18 +19,23 @@ properties:
> - enum:
> - microchip,ata6561
> - const: ti,tcan1042
> + - items:
> + - enum:
> + - nxp,tja1051
> + - const: ti,tcan1043
> - enum:
> - ti,tcan1042
> - ti,tcan1043
> + - nxp,tja1048
> - nxp,tjr1443
>
> - '#phy-cells':
> - const: 0
> + '#phy-cells': true
need restrict number, although you limit in allOf, still prefer provide
wide restriction here.
'phy-cells':
enum: [ 0, 1]
>
> standby-gpios:
> description:
> gpio node to toggle standby signal on transceiver
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> enable-gpios:
> description:
> @@ -53,12 +58,34 @@ required:
> - compatible
> - '#phy-cells'
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,tja1048
> + then:
> + properties:
> + '#phy-cells':
> + const: 1
> + standby-gpios:
> + minItems: 2
> + maxItems: 2
> + else:
> + properties:
> + '#phy-cells':
> + const: 0
> + standby-gpios:
> + minItems: 1
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
>
> +
uncessary change here
Frank
> transceiver1: can-phy {
> compatible = "ti,tcan1043";
> #phy-cells = <0>;
>
> --
> 2.37.1
>