The prerequisites section listed non-existent packages
"phython-gnuplot" and "phython3-gnuplot", which may mislead users and
cause installation failures.

Update the names to the correct distribution package names
"python-gnuplot" and "python3-gnuplot", helping users avoid confusion
and saving time for those following the instructions.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
 tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
index feb9f9421c7b..875b086550d1 100755
--- a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
+++ b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
@@ -11,7 +11,7 @@ Prerequisites:
     gnuplot 5.0 or higher
     gnuplot-py 1.8 or higher
     (Most of the distributions have these required packages. They may be called
-     gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
+     gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )
 
     Kernel config for Linux trace is enabled
 
-- 
2.34.1

On 8/24/2025 3:09 PM, Kuan-Wei Chiu wrote:
> The prerequisites section listed non-existent packages
> "phython-gnuplot" and "phython3-gnuplot", which may mislead users and
> cause installation failures.
> 
> Update the names to the correct distribution package names
> "python-gnuplot" and "python3-gnuplot", helping users avoid confusion
> and saving time for those following the instructions.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> index feb9f9421c7b..875b086550d1 100755
> --- a/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> +++ b/tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
> @@ -11,7 +11,7 @@ Prerequisites:
>       gnuplot 5.0 or higher
>       gnuplot-py 1.8 or higher
>       (Most of the distributions have these required packages. They may be called
> -     gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
> +     gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )
>   
>       Kernel config for Linux trace is enabled
>

Hi Mario,

On Mon, Aug 25, 2025 at 04:25:58PM -0500, Mario Limonciello wrote:
> On 8/24/2025 3:09 PM, Kuan-Wei Chiu wrote:
> > The prerequisites section listed non-existent packages
> > "phython-gnuplot" and "phython3-gnuplot", which may mislead users and
> > cause installation failures.
> > 
> > Update the names to the correct distribution package names
> > "python-gnuplot" and "python3-gnuplot", helping users avoid confusion
> > and saving time for those following the instructions.
> > 
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks for your review!

Since the merge window is likely opening in less than a week and this
patch has already been submitted and reviewed for about a month, I
noticed it still hasn't shown up in linux-next.

May I ask how we plan to route this patch?

Regards,
Kuan-Wei

On 9/23/25 11:21 AM, Kuan-Wei Chiu wrote:
> Hi Mario,
> 
> On Mon, Aug 25, 2025 at 04:25:58PM -0500, Mario Limonciello wrote:
>> On 8/24/2025 3:09 PM, Kuan-Wei Chiu wrote:
>>> The prerequisites section listed non-existent packages
>>> "phython-gnuplot" and "phython3-gnuplot", which may mislead users and
>>> cause installation failures.
>>>
>>> Update the names to the correct distribution package names
>>> "python-gnuplot" and "python3-gnuplot", helping users avoid confusion
>>> and saving time for those following the instructions.
>>>
>>> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
>>
>> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Thanks for your review!
> 
> Since the merge window is likely opening in less than a week and this
> patch has already been submitted and reviewed for about a month, I
> noticed it still hasn't shown up in linux-next.
> 
> May I ask how we plan to route this patch?
> 
> Regards,
> Kuan-Wei

Sorry about that!  I had thought being tools/ someone else would pick it 
up, but I suppose it does make sense to go through amd-pstate (followed 
by linux-pm).  I've picked it up and will send out a PR for linux-pm 
tomorrow or Thursday.